Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reexport of %||% #178

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix reexport of %||% #178

merged 2 commits into from
Jan 17, 2024

Conversation

mojaveazure
Copy link
Member

@mojaveazure mojaveazure commented Jan 9, 2024

Adjust reexport of %||% to be a proper reexport instead of a redefine. This should hopefully silence warnings in scCustomize

fixes #177

Adjust reexport of `%||%` to be a proper reexport instead of a redefine.
This should hopefully silence warnings in scCustomize

resolves #177
@mojaveazure mojaveazure linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@dcollins15 dcollins15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being so slow on this one - my intent was to be thorough and verify that the CRAN checks are passing for scCustomize but I got tripped up getting the ggrastr package installed.

I've been meaning to carve out some time to figure out what was happening but I keep getting pulled away by other things. Since this is such a small tweak and I don't want to keep blocking you I'll give this the +1 😬

Update changelog
@mojaveazure mojaveazure merged commit 64a9f57 into develop Jan 17, 2024
@mojaveazure mojaveazure deleted the fix/set-if-null branch January 17, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning with `%||% reexport from rlang
2 participants