Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to keys #180

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Updates to keys #180

merged 4 commits into from
Jan 19, 2024

Conversation

mojaveazure
Copy link
Member

This PR updates some infrastructure around keys:

  • Class warnings around keys
  • Simplify and stabilize logic around handling key warnings
  • Fix incorrect documentation
  • Add single place to refer to meta data keys

This PR also ups the minimum version of R to 4.1.0 to make use of lambdas

@dcollins15
Copy link
Collaborator

Excited to give this a proper read-through in the next day or so! 🔥

Are these changes expected to affect any particular behavior or is this mostly developer-oriented maintenance?

This PR updates some infrastructure around keys:
- Class warnings around keys
- Simplify and stabilize logic around handling key warnings
- Fix incorrect documentation
- Add single place to refer to meta data keys

This PR also ups the minimum version of R to 4.1.0 to make use of lambdas
This PR updates some infrastructure around keys:
- Class warnings around keys
- Simplify and stabilize logic around handling key warnings
- Fix incorrect documentation
- Add single place to refer to meta data keys

This PR also ups the minimum version of R to 4.1.0 to make use of lambdas
@mojaveazure
Copy link
Member Author

mojaveazure commented Jan 17, 2024

This is predominantly a developer-oriented update. The only user-facing changes are:

  • Discontinuing support for R 4.0 (R-release is R 4.3 and expected to become R 4.4. in the spring) due to the use of shorthand function syntax (\() instead of function() {}) for single-statement functions
  • Calling Key() on a character now requires explicit quiet = TRUE to suppress warnings. Previously, one could call
Key("mychar", TRUE)

to suppress the warning generated by updating a key, but now one must call

Key("mychar", quiet = TRUE)

to achieve the same effect

Copy link
Collaborator

@dcollins15 dcollins15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The lambda syntax is slick 😎

Is there any reason users might not want to upgrade to R 4.1.0? I can imagine folks being chuffed at a major upgrade but this seems like a small imposition to me 🤷

@mojaveazure
Copy link
Member Author

The biggest downside in upgrading from R 4.0 to R 4.1 is the need to re-install your package library (R package libraries are specific to the minor version). However, newer cycles of R v4 have introduced several niceities so pushing people to upgrade would be (IMO) a good thing (there's a few features of R 4.2 and 4.3 that I'd like to use, but won't at this point in time to maintain compatibility with R 4.1)

@mojaveazure mojaveazure merged commit ee82ea7 into develop Jan 19, 2024
@mojaveazure mojaveazure deleted the feat/key-updates branch January 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants