-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to keys #180
Updates to keys #180
Conversation
Excited to give this a proper read-through in the next day or so! 🔥 Are these changes expected to affect any particular behavior or is this mostly developer-oriented maintenance? |
This PR updates some infrastructure around keys: - Class warnings around keys - Simplify and stabilize logic around handling key warnings - Fix incorrect documentation - Add single place to refer to meta data keys This PR also ups the minimum version of R to 4.1.0 to make use of lambdas
b06cb45
to
63ecbc4
Compare
This PR updates some infrastructure around keys: - Class warnings around keys - Simplify and stabilize logic around handling key warnings - Fix incorrect documentation - Add single place to refer to meta data keys This PR also ups the minimum version of R to 4.1.0 to make use of lambdas
63ecbc4
to
a6c8fc0
Compare
This is predominantly a developer-oriented update. The only user-facing changes are:
Key("mychar", TRUE) to suppress the warning generated by updating a key, but now one must call Key("mychar", quiet = TRUE) to achieve the same effect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The lambda syntax is slick 😎
Is there any reason users might not want to upgrade to R 4.1.0
? I can imagine folks being chuffed at a major upgrade but this seems like a small imposition to me 🤷
The biggest downside in upgrading from R 4.0 to R 4.1 is the need to re-install your package library (R package libraries are specific to the minor version). However, newer cycles of R v4 have introduced several niceities so pushing people to upgrade would be (IMO) a good thing (there's a few features of R 4.2 and 4.3 that I'd like to use, but won't at this point in time to maintain compatibility with R 4.1) |
… into feat/key-updates
Bump develop version
This PR updates some infrastructure around keys:
This PR also ups the minimum version of R to 4.1.0 to make use of lambdas