-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render tag name without slug when title #179
Comments
I'm trying to rework this part of the code at the moment anyway, but it seems that I'm not able to reproduce your issue. Could you show me an example, where this happens? |
Ah, now I get it. I guess you could be right that in the end it boils down to personal taste. On the other hand, if you allow capitalized tags with spaces, why not show the original? One could argue, either allow and show them, or don't allow them. The thing is, with how the tags pages are implemented now, I believe the change wouldn't be as trivial as one might think. |
I'm curious, what do you mean? |
Because all of these files play somehow a role in it: https://github.com/satnaing/astro-paper/blob/main/src/pages/tags/%5Btag%5D.astro Maybe one could simply change the function getUniqueTags.ts to return the altered AND unaltered tag, and pass the unaltered tag to props in [tag].astro. But that might break other stuff, no idea. |
Update slugified titles to be unslugified. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified. Closes: #179
Update slugified titles to be unslugified in the tag page. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified. Closes: #179
Update slugified titles to be unslugified in the tag page. This is for better SEO and better a11y. Url and tag elelemnts will still be slugified. Closes: satnaing#179
When a tag contains more than one word it is slugified. (Yay!) However, this means the page title and meta title render with the hyphen too. (Nay!)
Maybe this is personal preference, but at least the H1 should be unslugified.
The text was updated successfully, but these errors were encountered: