Matching the metastring

Which is not a URL as I wrongly assumed in the previous release
saucelabs · May 25, 2023 · 0536c1d · 0536c1d
1 parent d606164
commit 0536c1d
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 26 deletions.
diff --git a/src/theme/ReferenceCodeBlock/index.tsx b/src/theme/ReferenceCodeBlock/index.tsx
@@ -51,24 +51,22 @@ export function parseReference (ref: string): GitHubReference {
     }
 }
 
-export function parseCustomization (ref: string): CustomizedLinkOptions {    
+export function parseCustomization (metastring: string | undefined): CustomizedLinkOptions {    
 
-    const url = new URL(ref);
+    const refTitle = metastring?.match(/title="(?<title>.*?)"/)?.groups?.title;
 
-    const urlTitle = url.searchParams.get('title');
-    const urlLinkText = url.searchParams.has('referenceLinkText') 
-        ? url.searchParams.get('referenceLinkText')
-        : DEFAULT_LINK_TEXT;
+    const refLinkMatch = metastring?.match(/referenceLinkText="(?<referenceLinkText>.*?)"/);
+    const refLinkText = refLinkMatch?.groups?.referenceLinkText ?? DEFAULT_LINK_TEXT;
 
-
-    const urlUseCustomStyling = url.searchParams.has('customStyling')
-    const urlNoteStyling = urlUseCustomStyling ? {} : noteStyle;
-    
+    const customStylingMatch = metastring?.match(/customStyling/);
+    const refUseCustomStyling = customStylingMatch?.length === 1;
+    const refNoteStyling = customStylingMatch?.length === 1 ? {} : noteStyle;
+
     return {
-        title: urlTitle,
-        linkText: urlLinkText,
-        noteStyling: urlNoteStyling,
-        useCustomStyling: urlUseCustomStyling
+        title: refTitle,
+        linkText: refLinkText,
+        noteStyling: refNoteStyling,
+        useCustomStyling: refUseCustomStyling
     }
 }
 
@@ -136,7 +134,7 @@ function ReferenceCode(props: ReferenceCodeBlockProps) {
         fetchCode(codeSnippetDetails, fetchResultStateDispatcher)
     }
 
-    const parsedCustomization = parseCustomization(props.children)
+    const parsedCustomization = parseCustomization(props.metastring)
 
     const customProps = {
         ...props,

diff --git a/src/theme/types.ts b/src/theme/types.ts
@@ -19,8 +19,8 @@ export interface DispatchMessage {
 }
 
 export interface CustomizedLinkOptions {
-    title: string | null
-    linkText: string | null
+    title: string | undefined
+    linkText: string
     noteStyling: React.CSSProperties
     useCustomStyling: boolean
 }
diff --git a/tests/ReferenceCodeBlock.test.ts b/tests/ReferenceCodeBlock.test.ts
@@ -8,11 +8,11 @@ test('should parse GitHub reference properly', () => {
 })
 
 test('should use custom reference link text', () => {
-    expect(parseCustomization('https://github.com/saucelabs/docusaurus-theme-github-codeblock/blob/main/src/theme/ReferenceCodeBlock/index.tsx?referenceLinkText="Sample text"'))
+    expect(parseCustomization('referenceLinkText="Sample text"'))
         .toMatchSnapshot()
-    expect(parseCustomization('https://github.com/saucelabs/docusaurus-theme-github-codeblock/blob/main/src/theme/ReferenceCodeBlock/index.tsx?referenceLinkText="Sample text"&title="Sample title"'))
+    expect(parseCustomization('referenceLinkText="Sample text" title="Sample title"'))
         .toMatchSnapshot()
-    expect(parseCustomization('https://github.com/saucelabs/docusaurus-theme-github-codeblock/blob/main/src/theme/ReferenceCodeBlock/index.tsx?referenceLinkText="Sample text"&title="Sample title"&customStyling'))
+    expect(parseCustomization('referenceLinkText="Sample text" title="Sample title" customStyling'))
         .toMatchSnapshot()
 })
 

diff --git a/tests/__snapshots__/ReferenceCodeBlock.test.ts.snap b/tests/__snapshots__/ReferenceCodeBlock.test.ts.snap
@@ -51,7 +51,7 @@ Object {
 
 exports[`should use custom reference link text 1`] = `
 Object {
-  "linkText": "\\"Sample text\\"",
+  "linkText": "Sample text",
   "noteStyling": Object {
     "color": "#0E75DD",
     "fontSize": ".9em",
@@ -60,14 +60,14 @@ Object {
     "textAlign": "center",
     "textDecoration": "underline",
   },
-  "title": null,
+  "title": undefined,
   "useCustomStyling": false,
 }
 `;
 
 exports[`should use custom reference link text 2`] = `
 Object {
-  "linkText": "\\"Sample text\\"",
+  "linkText": "Sample text",
   "noteStyling": Object {
     "color": "#0E75DD",
     "fontSize": ".9em",
@@ -76,16 +76,16 @@ Object {
     "textAlign": "center",
     "textDecoration": "underline",
   },
-  "title": "\\"Sample title\\"",
+  "title": "Sample title",
   "useCustomStyling": false,
 }
 `;
 
 exports[`should use custom reference link text 3`] = `
 Object {
-  "linkText": "\\"Sample text\\"",
+  "linkText": "Sample text",
   "noteStyling": Object {},
-  "title": "\\"Sample title\\"",
+  "title": "Sample title",
   "useCustomStyling": true,
 }
 `;