Skip to content

Commit

Permalink
tweak package size
Browse files Browse the repository at this point in the history
  • Loading branch information
saudiwin committed Feb 12, 2023
1 parent 274dff2 commit 53887a1
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 28 deletions.
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.5.0
Date: 2022-10-25 04:47:42 UTC
SHA: 591c34a50aa7e30693c33dadcaf964c3094d105b
Version: 0.7.0
Date: 2023-02-10 13:01:25 UTC
SHA: 274dff201302c0f068d8559215c6b076ab36120f
25 changes: 4 additions & 21 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,14 @@
0 errors | 0 warnings | 1 notes

❯ checking installed package size ... NOTE
installed size is 13.4Mb
installed size is 9.5Mb
sub-directories of 1Mb or more:
data 10.0Mb
doc 3.3Mb
data 6.1Mb
doc 3.2Mb

The data sub-directory contains fitted models that are used to illustrate function examples because fitting the model can take up to an hour.

Submitting to win-release results in 1 ERROR:

Error(s) in re-building vignettes:
--- re-building 'package_introduction.Rmd' using rmarkdown
Quitting from lines 247-258 (package_introduction.Rmd)
Error: processing vignette 'package_introduction.Rmd' failed with diagnostics:
could not find function "avg_slopes"
--- failed re-building 'package_introduction.Rmd'

SUMMARY: processing the following file failed:
'package_introduction.Rmd'

Error: Vignette re-building failed.
Execution halted

Submitting to win-devel results in OK status - no NOTEs or WARNINGs.

The error in win-release appears to be due to the fact the marginaleffects package, which has the avg_slopes function, does not have a binary available for windows for the current version of the package, 0.9.0. This is the required version listed under the Suggests field in ordbetareg but win-release is installing an older version that does not have the avg_slopes function. However, it is necessary to update to 0.9.0 as otherwise the package vignette fails to compile, and I received an email from the CRAN maintainer requesting that I update the package to handle marginaleffects 0.9.0--see build logs at https://cran.r-project.org/web/checks/check_results_ordbetareg.html. If I do not update the package by 2-16-2023, it will be removed from CRAN.

As such, it would seem that this error in win-release should be ignored as it is not clear why it is not installing the current version of marginaleffects, which has been available since Feb 1 2023.
Submitting to win-release results in OK status - no NOTEs or WARNINGs.

Binary file modified data/fit_imputed.rda
Binary file not shown.
Binary file modified data/fit_multivariate.rda
Binary file not shown.
Binary file modified data/ord_fit_mean.rda
Binary file not shown.
Binary file modified data/ord_fit_phi.rda
Binary file not shown.
10 changes: 6 additions & 4 deletions vignettes/package_introduction.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ if(run_model) {
(1|region),
data=model_data,
control=list(adapt_delta=0.95),
cores=2,chains=2,iter=1000,
cores=2,chains=2,iter=500,
refresh=0)
# NOTE: to do parallel processing within chains
# add the options below
Expand Down Expand Up @@ -339,7 +339,8 @@ if(run_model) {
fit_imputed <- ordbetareg(formula = outcome ~ X,
data=mult_impute,
use_brm_multiple = T)
use_brm_multiple = T,
cores=1,chains=1, iter=500)
} else {
Expand Down Expand Up @@ -386,7 +387,8 @@ if(run_model) {
fit_multivariate <- ordbetareg(formula=mod1 + mod2 + set_rescor(FALSE),
data=tibble(outcome=outcome,
X=X,Z=Z))
X=X,Z=Z),
cores=1,chains=1, iter=500)
}
Expand Down Expand Up @@ -425,7 +427,7 @@ if(run_model) {
phi ~ age + sex),
phi_reg = T,
data=model_data,
cores=2,chains=2,iter=1000,
cores=2,chains=2,iter=500,
refresh=0)
# NOTE: to do parallel processing within chains
# add the options below
Expand Down

0 comments on commit 53887a1

Please sign in to comment.