Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Imlimenting clickable contact info. #23

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

Amarjha01
Copy link
Contributor

@Amarjha01 Amarjha01 commented Oct 1, 2024

🛠️ Fixes Issue #11

Closes #11

Title:
Implemented clickable footer contact info

Description

Implementation of clickable footer contact info. Now when user click on location the user will redirect to google map , as well when user will click on email that will redirect to mail application similarly when user will click on phoneNo. that will redirect to calling applicatin.

Checklist

  • I have tested my code and it works as expected.
  • I have followed the project's coding standards.

@thakuratul2
Copy link
Collaborator

@Amarjha01 I will review the code before after that I will merge

Meanwhile find new issue

@Amarjha01
Copy link
Contributor Author

@Amarjha01 I will review the code before after that I will merge

Meanwhile find new issue

sure sir

@thakuratul2 thakuratul2 mentioned this pull request Oct 2, 2024
11 tasks
@thakuratul2
Copy link
Collaborator

@Amarjha01 your request having some conflicts and pull request description is not proper according to gssoc guidelines

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrollme-ecommerce-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:17am

@thakuratul2
Copy link
Collaborator

@Amarjha01 create it again and please give request to develop branch

Copy link
Collaborator

@thakuratul2 thakuratul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@thakuratul2 thakuratul2 merged commit 4a851eb into saurabhbakolia:develop Oct 2, 2024
1 check passed
@Amarjha01
Copy link
Contributor Author

Is successfully merged and deployed sir ?

@thakuratul2
Copy link
Collaborator

thakuratul2 commented Oct 2, 2024 via email

@thakuratul2
Copy link
Collaborator

@Amarjha01 it also deployed in vercel

@StrugglerSuryansh StrugglerSuryansh mentioned this pull request Oct 2, 2024
11 tasks
@Amarjha01 Amarjha01 mentioned this pull request Oct 2, 2024
11 tasks
@Amarjha01
Copy link
Contributor Author

@thakuratul2 @saurabhbakolia sir can you please assign me and add labels. because point is not showing on leader board.

@saras-69 saras-69 mentioned this pull request Oct 20, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants