Skip to content

Commit

Permalink
Remove DIKTAT_RULE_SET_ID from expected lint errors (ignored in the…
Browse files Browse the repository at this point in the history
… new ktlint)
  • Loading branch information
0x6675636b796f75676974687562 committed Oct 25, 2022
1 parent 311c34e commit 5a8a39d
Show file tree
Hide file tree
Showing 82 changed files with 105 additions and 187 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter1

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.BACKTICKS_PROHIBITED
import org.cqfn.diktat.ruleset.constants.Warnings.CLASS_NAME_INCORRECT
Expand All @@ -25,7 +24,7 @@ import org.junit.jupiter.api.Tags
import org.junit.jupiter.api.Test

class IdentifierNamingWarnTest : LintTestBase(::IdentifierNaming) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${IdentifierNaming.NAME_ID}"
private val ruleId: String = IdentifierNaming.NAME_ID
private val rulesConfigBooleanFunctions: List<RulesConfig> = listOf(
RulesConfig(FUNCTION_BOOLEAN_PREFIX.name, true,
mapOf("allowedPrefixes" to "equals, equivalent, foo"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter1

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.FUNCTION_BOOLEAN_PREFIX
import org.cqfn.diktat.ruleset.constants.Warnings.FUNCTION_NAME_INCORRECT_CASE
import org.cqfn.diktat.ruleset.constants.Warnings.TYPEALIAS_NAME_INCORRECT_CASE
Expand All @@ -13,7 +12,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class MethodNamingWarnTest : LintTestBase(::IdentifierNaming) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${IdentifierNaming.NAME_ID}"
private val ruleId: String = IdentifierNaming.NAME_ID

@Test
@Tag(WarningNames.FUNCTION_NAME_INCORRECT_CASE)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter1

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.INCORRECT_PACKAGE_SEPARATOR
import org.cqfn.diktat.ruleset.constants.Warnings.PACKAGE_NAME_INCORRECT_CASE
Expand All @@ -18,7 +17,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class PackageNamingWarnTest : LintTestBase(::PackageNaming) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${PackageNaming.NAME_ID}"
private val ruleId: String = PackageNaming.NAME_ID
private val rulesConfigList: List<RulesConfig> = listOf(
RulesConfig("DIKTAT_COMMON", true, mapOf("domainName" to "org.cqfn.diktat"))
)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.constants.Warnings.IF_ELSE_COMMENTS
import org.cqfn.diktat.ruleset.rules.chapter2.kdoc.CommentsFormatting
Expand All @@ -13,7 +12,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class CommentsFormattingTest : LintTestBase(::CommentsFormatting) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${CommentsFormatting.NAME_ID}"
private val ruleId = CommentsFormatting.NAME_ID

@Test
@Tag(WarningNames.COMMENT_WHITE_SPACE)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.constants.Warnings.HEADER_MISSING_IN_NON_SINGLE_CLASS_FILE
Expand All @@ -18,7 +17,7 @@ import org.junit.jupiter.api.Test
import java.time.LocalDate

class HeaderCommentRuleTest : LintTestBase(::HeaderCommentRule) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${HeaderCommentRule.NAME_ID}"
private val ruleId: String = HeaderCommentRule.NAME_ID
private val curYear = LocalDate.now().year
private val rulesConfigList: List<RulesConfig> = listOf(
RulesConfig("HEADER_MISSING_OR_WRONG_COPYRIGHT", true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_EXTRA_PROPERTY
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_NO_CLASS_BODY_PROPERTIES_IN_HEADER
Expand All @@ -18,7 +17,7 @@ import org.junit.jupiter.api.Tags
import org.junit.jupiter.api.Test

class KdocCommentsWarnTest : LintTestBase(::KdocComments) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${KdocComments.NAME_ID}"
private val ruleId: String = KdocComments.NAME_ID

@Test
@Tag(WarningNames.COMMENTED_BY_KDOC)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_EMPTY_KDOC
Expand All @@ -20,7 +19,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class KdocFormattingTest : LintTestBase(::KdocFormatting) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${KdocFormatting.NAME_ID}"
private val ruleId: String = KdocFormatting.NAME_ID
private val funCode = """
fun foo(a: Int): Int {
if (false) throw IllegalStateException()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_COMMON
import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_TRIVIAL_KDOC_ON_FUNCTION
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_WITHOUT_PARAM_TAG
Expand All @@ -18,7 +17,7 @@ import org.junit.jupiter.api.Tags
import org.junit.jupiter.api.Test

class KdocMethodsTest : LintTestBase(::KdocMethods) {
private val ruleId: String = "$DIKTAT_RULE_SET_ID:${KdocMethods.NAME_ID}"
private val ruleId: String = KdocMethods.NAME_ID
private val funCode = """
fun doubleInt(a: Int): Int {
if (Config.condition) throw IllegalStateException()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.KDOC_WITHOUT_PARAM_TAG
import org.cqfn.diktat.ruleset.constants.Warnings.MISSING_KDOC_ON_FUNCTION
import org.cqfn.diktat.ruleset.rules.chapter2.kdoc.KdocMethods
Expand All @@ -13,7 +12,7 @@ import org.junit.jupiter.api.Tags
import org.junit.jupiter.api.Test

class KdocParamPresentWarnTest : LintTestBase(::KdocMethods) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${KdocMethods.NAME_ID}"
private val ruleId = KdocMethods.NAME_ID

@Test
@Tag(WarningNames.KDOC_WITHOUT_PARAM_TAG)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter2.comments

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.COMMENTED_OUT_CODE
import org.cqfn.diktat.ruleset.rules.chapter2.comments.CommentsRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class CommentedCodeTest : LintTestBase(::CommentsRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${CommentsRule.NAME_ID}"
private val ruleId = CommentsRule.NAME_ID

@Test
@Tag(WarningNames.COMMENTED_OUT_CODE)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.rules.chapter3.AnnotationNewLineRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class AnnotationNewLineRuleWarnTest : LintTestBase(::AnnotationNewLineRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${AnnotationNewLineRule.NAME_ID}"
private val ruleId = AnnotationNewLineRule.NAME_ID

@Test
@Tag(WarningNames.ANNOTATION_NEW_LINE)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.BRACES_BLOCK_STRUCTURE_ERROR
import org.cqfn.diktat.ruleset.rules.chapter3.BlockStructureBraces
Expand All @@ -12,7 +11,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class BlockStructureBracesWarnTest : LintTestBase(::BlockStructureBraces) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${BlockStructureBraces.NAME_ID}"
private val ruleId = BlockStructureBraces.NAME_ID
private val rulesConfigList: List<RulesConfig> = listOf(
RulesConfig(BRACES_BLOCK_STRUCTURE_ERROR.name, true,
mapOf("openBraceNewline" to "False", "closeBraceNewline" to "False"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.rules.chapter3.BooleanExpressionsRule
import org.cqfn.diktat.ruleset.utils.KotlinParser
Expand All @@ -15,7 +14,7 @@ import java.io.ByteArrayOutputStream
import java.io.PrintStream

class BooleanExpressionsRuleWarnTest : LintTestBase(::BooleanExpressionsRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${BooleanExpressionsRule.NAME_ID}"
private val ruleId = BooleanExpressionsRule.NAME_ID

@Test
@Tag(WarningNames.COMPLEX_BOOLEAN_EXPRESSION)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.NO_BRACES_IN_CONDITIONALS_AND_LOOPS
import org.cqfn.diktat.ruleset.rules.chapter3.BracesInConditionalsAndLoopsRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class BracesRuleWarnTest : LintTestBase(::BracesInConditionalsAndLoopsRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${BracesInConditionalsAndLoopsRule.NAME_ID}"
private val ruleId = BracesInConditionalsAndLoopsRule.NAME_ID

@Test
@Tag(WarningNames.NO_BRACES_IN_CONDITIONALS_AND_LOOPS)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.chapter3.spaces.describe
import org.cqfn.diktat.ruleset.constants.Warnings.BLANK_LINE_BETWEEN_PROPERTIES
import org.cqfn.diktat.ruleset.constants.Warnings.WRONG_ORDER_IN_CLASS_LIKE_STRUCTURES
Expand All @@ -15,7 +14,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class ClassLikeStructuresOrderRuleWarnTest : LintTestBase(::ClassLikeStructuresOrderRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${ClassLikeStructuresOrderRule.NAME_ID}"
private val ruleId = ClassLikeStructuresOrderRule.NAME_ID

// ===== order of declarations =====

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.COLLAPSE_IF_STATEMENTS
import org.cqfn.diktat.ruleset.rules.chapter3.CollapseIfStatementsRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class CollapseIfStatementsRuleWarnTest : LintTestBase(::CollapseIfStatementsRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${CollapseIfStatementsRule.NAME_ID}"
private val ruleId = CollapseIfStatementsRule.NAME_ID

@Test
@Tag(WarningNames.COLLAPSE_IF_STATEMENTS)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.TOO_MANY_CONSECUTIVE_SPACES
import org.cqfn.diktat.ruleset.rules.chapter3.ConsecutiveSpacesRule
Expand All @@ -12,7 +11,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class ConsecutiveSpacesRuleWarnTest : LintTestBase(::ConsecutiveSpacesRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${ConsecutiveSpacesRule.NAME_ID}"
private val ruleId = ConsecutiveSpacesRule.NAME_ID
private val rulesConfigListNoSpaces: List<RulesConfig> = listOf(
RulesConfig(TOO_MANY_CONSECUTIVE_SPACES.name, true,
mapOf("maxSpaces" to "2"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.rules.chapter3.DebugPrintRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class DebugPrintRuleWarnTest : LintTestBase(::DebugPrintRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${DebugPrintRule.NAME_ID}"
private val ruleId = DebugPrintRule.NAME_ID

@Test
@Tag(WarningNames.DEBUG_PRINT)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.EMPTY_BLOCK_STRUCTURE_ERROR
import org.cqfn.diktat.ruleset.rules.chapter3.EmptyBlock
Expand All @@ -12,7 +11,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class EmptyBlockWarnTest : LintTestBase(::EmptyBlock) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${EmptyBlock.NAME_ID}"
private val ruleId = EmptyBlock.NAME_ID
private val rulesConfigListIgnoreEmptyBlock: List<RulesConfig> = listOf(
RulesConfig(EMPTY_BLOCK_STRUCTURE_ERROR.name, true,
mapOf("styleEmptyBlockWithNewline" to "False"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings.ENUMS_SEPARATED
import org.cqfn.diktat.ruleset.rules.chapter3.EnumsSeparated
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -11,7 +10,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class EnumsSeparatedWarnTest : LintTestBase(::EnumsSeparated) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${EnumsSeparated.NAME_ID}"
private val ruleId = EnumsSeparated.NAME_ID

@Test
@Tag(WarningNames.ENUMS_SEPARATED)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.rules.chapter3.files.FileSize
Expand All @@ -14,7 +13,7 @@ import org.junit.jupiter.api.Test
import java.io.File

class FileSizeWarnTest : LintTestBase(::FileSize) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${FileSize.NAME_ID}"
private val ruleId = FileSize.NAME_ID
private val rulesConfigListLarge: List<RulesConfig> = listOf(
RulesConfig(Warnings.FILE_IS_TOO_LONG.name, true,
mapOf("maxSize" to "5"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.constants.Warnings.FILE_CONTAINS_ONLY_COMMENTS
Expand All @@ -18,7 +17,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class FileStructureRuleTest : LintTestBase(::FileStructureRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${FileStructureRule.NAME_ID}"
private val ruleId = FileStructureRule.NAME_ID
private val rulesConfigListWildCardImport: List<RulesConfig> = listOf(
RulesConfig(FILE_WILDCARD_IMPORTS.name, true,
mapOf("allowedWildcards" to "org.cqfn.diktat.*"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.common.config.rules.RulesConfig
import org.cqfn.diktat.ruleset.constants.Warnings.LONG_LINE
import org.cqfn.diktat.ruleset.rules.chapter3.LineLength
Expand All @@ -14,7 +13,7 @@ import org.junit.jupiter.api.Tag
import org.junit.jupiter.api.Test

class LineLengthWarnTest : LintTestBase(::LineLength) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${LineLength.NAME_ID}"
private val ruleId = LineLength.NAME_ID
private val rulesConfigListLineLength: List<RulesConfig> = listOf(
RulesConfig(LONG_LINE.name, true,
mapOf("lineLength" to "163"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.cqfn.diktat.ruleset.chapter3

import org.cqfn.diktat.common.config.rules.DIKTAT_RULE_SET_ID
import org.cqfn.diktat.ruleset.constants.Warnings
import org.cqfn.diktat.ruleset.rules.chapter3.identifiers.LocalVariablesRule
import org.cqfn.diktat.util.LintTestBase
Expand All @@ -13,7 +12,7 @@ import org.junit.jupiter.api.Test

@Suppress("LargeClass")
class LocalVariablesWarnTest : LintTestBase(::LocalVariablesRule) {
private val ruleId = "$DIKTAT_RULE_SET_ID:${LocalVariablesRule.NAME_ID}"
private val ruleId = LocalVariablesRule.NAME_ID

private fun warnMessage(name: String,
declared: Int,
Expand Down
Loading

0 comments on commit 5a8a39d

Please sign in to comment.