BooleanExpressionRule fixes #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ preserve order in variables
…ution issue (replacement of sub-word)
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
============================================
+ Coverage 81.97% 82.01% +0.03%
- Complexity 2527 2530 +3
============================================
Files 105 105
Lines 7169 7201 +32
Branches 2053 2058 +5
============================================
+ Hits 5877 5906 +29
Misses 346 346
- Partials 946 949 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
May 25, 2022
|
|
||
| fun size(): Int = replacements.size | ||
|
|
||
| fun getTokenMapper(): TokenMapper<String> = orderTokenMapper |
There was a problem hiding this comment.
I think a getter for this is redundant, because you can have a public val with the same effect as private field with public getter
There was a problem hiding this comment.
Thanks for suggestion, fixed
### What's done: * removed tokenMapper function and opened the variable orderedTokenMapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
This pull request closes #1284 and #961
BooleanExpressionRule:
A & B & C->isBar & B & C->isfooar & foo & CandisAdd && isAdded()->A & Aed!isEmpty()->AisA && isB is isC->isC && isA && isCActions checklist
Fixme
distributive law, need to implement it as a rule for jbool library (will be handled in BooleanExpressionRule: refactor a logic of the distributive law as a rule for jbool library #1299)