Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename s/analysis-dev/saveourtool/g in URLs #1311

Merged

Conversation

unix-junkie
Copy link
Contributor

What's done:

  • URLs (incl. those from badges) have been corrected to accommodate for the organization name change.

@unix-junkie unix-junkie force-pushed the bugfix/andrey.shcheglov/readme-badge-fix branch from 345d5c1 to 0265e99 Compare May 27, 2022 11:06
@unix-junkie unix-junkie enabled auto-merge (squash) May 27, 2022 11:06
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1311 (feea20c) into master (44507fd) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1311   +/-   ##
=========================================
  Coverage     82.08%   82.08%           
  Complexity     2538     2538           
=========================================
  Files           105      105           
  Lines          7223     7223           
  Branches       2065     2065           
=========================================
  Hits           5929     5929           
  Misses          346      346           
  Partials        948      948           
Flag Coverage Δ
unittests 82.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 86.53% <ø> (ø)
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 66.66% <0.00%> (ø)
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt 79.46% <ø> (ø)
...qfn/diktat/ruleset/rules/chapter4/SmartCastRule.kt 50.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44507fd...feea20c. Read the comment docs.

README.md Outdated
@@ -3,7 +3,7 @@
![Build and test](https://github.com/cqfn/diKTat/workflows/Build%20and%20test/badge.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these urls need to be updated too:
https://github.com/cqfn/diKTat to https://github.com/saveourtool/diktat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nulls, this has been addressed with 49bbef2.

@unix-junkie unix-junkie requested a review from nulls May 27, 2022 13:18
Copy link
Member

@nulls nulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated

[![Releases](https://img.shields.io/github/v/release/cqfn/diKTat)](https://github.com/cqfn/diKTat/releases)
[![Releases](https://img.shields.io/github/v/release/saveourtool/diKTat)](https://github.com/saveourtool/diKTat/releases)
[![Maven Central](https://img.shields.io/maven-central/v/org.cqfn.diktat/diktat-rules)](https://mvnrepository.com/artifact/org.cqfn.diktat)
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fcqfn%2FdiKTat.svg?type=shield)](https://app.fossa.com/projects/git%2Bgithub.com%2Fcqfn%2FdiKTat?ref=badge_shield)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akuleshov7, looks like we need to change url on FOSSA too: https://app.fossa.com/projects/git%2Bgithub.com%2Fsaveourtool%2FdiKTat?ref=badge_shield -- doesn't work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with 1235197, but @akuleshov7 please take a look first.

@unix-junkie unix-junkie disabled auto-merge May 27, 2022 13:32
@@ -7,7 +7,7 @@

[![Releases](https://img.shields.io/github/v/release/saveourtool/diKTat)](https://github.com/saveourtool/diKTat/releases)
[![Maven Central](https://img.shields.io/maven-central/v/org.cqfn.diktat/diktat-rules)](https://mvnrepository.com/artifact/org.cqfn.diktat)
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fcqfn%2FdiKTat.svg?type=shield)](https://app.fossa.com/projects/git%2Bgithub.com%2Fcqfn%2FdiKTat?ref=badge_shield)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@nulls nulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

unix-junkie and others added 5 commits May 27, 2022 19:16
### What's done:

 * URLs (incl. those from badges) have been corrected to accommodate for the organization name change.
### What's done:

 * URLs (incl. those from badges) have been corrected to accommodate for the organization name change.
### What's done:

 * URLs (incl. those from badges) have been corrected to accommodate for the organization name change.
…s` to `false`

### What's done:

 * The `WRONG_INDENTATION:extendedIndentOfParameters` flag is now unset by default. This closes #1312.
…s` to `false`

### What's done:

 * The `WRONG_INDENTATION:extendedIndentOfParameters` flag is now unset by default. This closes #1312.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 force-pushed the bugfix/andrey.shcheglov/readme-badge-fix branch from e49a413 to feea20c Compare May 27, 2022 16:16
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 deleted the bugfix/andrey.shcheglov/readme-badge-fix branch May 27, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants