Fix for NSFE when mvn test run from /diktat-rules #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
=========================================
Coverage 83.67% 83.67%
Complexity 2588 2588
=========================================
Files 106 106
Lines 7387 7387
Branches 2048 2048
=========================================
Hits 6181 6181
Misses 354 354
Partials 852 852
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: - added arguments for methods in Generation.kt
petertrr
approved these changes
Jun 16, 2022
| validateYear() | ||
| fun main(args: Array<String>) { | ||
| require(args.size == 2) { | ||
| "Only to arguments are expected" |
There was a problem hiding this comment.
Suggested change
| "Only to arguments are expected" | |
| "Only two arguments are expected: <source root> <test resource root>" |
Maybe something like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Which rule and warnings did you add?
This pull request closes #1345