Support DistributiveLaw as jbool.Rule #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 12 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
============================================
- Coverage 83.55% 83.53% -0.03%
+ Complexity 2581 2552 -29
============================================
Files 106 106
Lines 7529 7517 -12
Branches 2084 2081 -3
============================================
- Hits 6291 6279 -12
- Misses 358 359 +1
+ Partials 880 879 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BooleanExpressionsRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BooleanExpressionsRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BooleanExpressionsRule.kt
Fixed
Show fixed
Hide fixed
nulls
force-pushed
the
feature/distributive-law
branch
from
fd488de
to
28f4899
Compare
orchestr7
reviewed
Jun 17, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/BooleanExpressionsRule.kt
Show resolved
Hide resolved
orchestr7
reviewed
Jun 17, 2022
diktat-rules/src/test/resources/test/paragraph3/boolean_expressions/DistributiveLawExpected.kt
Show resolved
Hide resolved
|
A tag for |
### What's done: - implemented DistributiveLaw extends com.bpodgursky.jbool_expressions.rules.Rule.Rule
nulls
force-pushed
the
feature/distributive-law
branch
from
cf887de
to
476d4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #1299