Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests which reproduce #1347 #1371

Conversation

0x6675636b796f75676974687562
Copy link
Member

What's done:

  • Running mvn diktat:fix with WRONG_INDENTATION rule enabled injects
    whitespace into multiline string literals. Now, unit tests were added which
    reproduce this behaviour.

Actions checklist

  • Added tests on fixers

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added the tests Improve testing label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1371 (cd2c5f5) into master (c98f051) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1371   +/-   ##
=========================================
  Coverage     83.55%   83.55%           
  Complexity     2581     2581           
=========================================
  Files           106      106           
  Lines          7529     7529           
  Branches       2084     2084           
=========================================
  Hits           6291     6291           
  Misses          358      358           
  Partials        880      880           
Flag Coverage Δ
unittests 83.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98f051...cd2c5f5. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 260 tests   1 240 ✔️  13m 45s ⏱️
   151 suites       20 💤
   151 files           0

Results for commit cd2c5f5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 260 tests   1 240 ✔️  9m 21s ⏱️
   151 suites       20 💤
   151 files           0

Results for commit cd2c5f5.

♻️ This comment has been updated with latest results.

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 force-pushed the feature/andrey.shcheglov/indentation-unit-tests branch from 1f02e2c to f7a71d8 Compare June 16, 2022 17:10
### What's done:

 * Running `mvn diktat:fix` with `WRONG_INDENTATION` rule enabled injects
   whitespace into multiline string literals. Now, unit tests were added which
   reproduce this behaviour.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 force-pushed the feature/andrey.shcheglov/indentation-unit-tests branch from f7a71d8 to cd2c5f5 Compare June 16, 2022 17:13
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 deleted the feature/andrey.shcheglov/indentation-unit-tests branch June 17, 2022 08:46
@nulls nulls added this to the 1.2.0 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WRONG_INDENTATION: running mvn diktat:fix adds whitespace to string literals
3 participants