-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests which reproduce #1347 #1371
Merged
0x6675636b796f75676974687562
merged 1 commit into
master
from
feature/andrey.shcheglov/indentation-unit-tests
Jun 17, 2022
Merged
Add unit tests which reproduce #1347 #1371
0x6675636b796f75676974687562
merged 1 commit into
master
from
feature/andrey.shcheglov/indentation-unit-tests
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...at-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationRuleTestMixin.kt
Fixed
Show fixed
Hide fixed
...at-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationRuleTestMixin.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=========================================
Coverage 83.55% 83.55%
Complexity 2581 2581
=========================================
Files 106 106
Lines 7529 7529
Branches 2084 2084
=========================================
Hits 6291 6291
Misses 358 358
Partials 880 880
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
June 16, 2022 17:10
1f02e2c
to
f7a71d8
Compare
### What's done: * Running `mvn diktat:fix` with `WRONG_INDENTATION` rule enabled injects whitespace into multiline string literals. Now, unit tests were added which reproduce this behaviour.
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
June 16, 2022 17:13
f7a71d8
to
cd2c5f5
Compare
petertrr
reviewed
Jun 17, 2022
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationRuleFixTest.kt
Show resolved
Hide resolved
petertrr
approved these changes
Jun 17, 2022
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
June 17, 2022 08:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
mvn diktat:fix
withWRONG_INDENTATION
rule enabled injectswhitespace into multiline string literals. Now, unit tests were added which
reproduce this behaviour.
Actions checklist