Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected analysis if maximum lineLength drop in first symbol of the last word long binary expression #1389

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

Arrgentum
Copy link
Member

@Arrgentum Arrgentum commented Jun 21, 2022

Description bug:

Whats added:

  • Corrected analysis if maximum lineLength drop in first symbol of the last word long binary expression
  • Delete 2 unused test in DiktatSmokeTest
  • Added 1 fix test split long binary expression with maximum lineLength = offset last word in binary expression

This pull request closes #1385

 * Corrected analysis if maximum lineLength drop in first symbol last word long binary expression
 * Delete 2 unused test in DiktatSmokeTest
 * Added 1 fix test split long binary expression with maximum lineLength = offset last word in binary expression
 * install
 * fix

### Issue(#1385)
@Arrgentum Arrgentum self-assigned this Jun 21, 2022
@Arrgentum Arrgentum changed the title ### Whats added: Corrected analysis if maximum lineLength drop in first symbol of the last word long binary expression Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1389 (5f71e20) into master (bc8d5d9) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1389   +/-   ##
=========================================
  Coverage     83.30%   83.30%           
  Complexity     2554     2554           
=========================================
  Files           107      107           
  Lines          7565     7565           
  Branches       2090     2090           
=========================================
  Hits           6302     6302           
  Misses          373      373           
  Partials        890      890           
Flag Coverage Δ
unittests 83.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/cqfn/diktat/ruleset/rules/chapter3/LineLength.kt 84.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8d5d9...5f71e20. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 262 tests   1 246 ✔️  11m 10s ⏱️
   151 suites       16 💤
   151 files           0

Results for commit 5f71e20.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 262 tests   1 246 ✔️  9m 7s ⏱️
   151 suites       16 💤
   151 files           0

Results for commit 5f71e20.

♻️ This comment has been updated with latest results.

Copy link
Member

@nulls nulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Arrgentum Arrgentum merged commit 57af86c into master Jun 22, 2022
@Arrgentum Arrgentum deleted the bugfix/checkLongBinaryExpression branch June 22, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect fix mode in LongLine rule
3 participants