Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: target Kotlin runtime 1.6 #1419

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 1, 2022

Since Gradle's embedded Kotlin support runtime target 1.4, we should decrease target of diktat-gradle-plugin and its transitive dependencies to be able to reference it in Gradle precompiled plugins, e.g. buildSrc.

What's done:

  • Changed dependency in diktat-gradle-plugin/pom.xml from diktat-rule sto diktat-common
  • Build diktat-common for languageVersion 1.6

### What's done:
* Changed dependency in diktat-gradle-plugin/pom.xml from diktat-rule sto diktat-common
* Build diktat-common for languageVersion 1.6
@petertrr petertrr changed the title gradle-plugin: make compatible with Kotlin runtime 1.5 gradle-plugin: target Kotlin runtime 1.6 Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1419 (b9a5ab7) into master (72b43ad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1419   +/-   ##
=========================================
  Coverage     83.37%   83.37%           
  Complexity     2561     2561           
=========================================
  Files           107      107           
  Lines          7604     7604           
  Branches       2100     2100           
=========================================
  Hits           6340     6340           
  Misses          374      374           
  Partials        890      890           
Flag Coverage Δ
unittests 83.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b43ad...b9a5ab7. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

   159 files     159 suites   34m 57s ⏱️
1 280 tests 1 262 ✔️ 15 💤 3
1 283 runs  1 265 ✔️ 15 💤 3

For more details on these failures, see this check.

Results for commit b9a5ab7.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   159 files     159 suites   18m 2s ⏱️
1 280 tests 1 264 ✔️ 15 💤 1
1 281 runs  1 265 ✔️ 15 💤 1

For more details on these failures, see this check.

Results for commit b9a5ab7.

@petertrr petertrr requested a review from orchestr7 July 1, 2022 12:08
@petertrr petertrr merged commit f44aa97 into master Jul 1, 2022
@petertrr petertrr deleted the bugfix/gradle-plugin branch July 1, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants