Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency io.github.microutils:kotlin-logging-jvm to v3 #1529

Merged
merged 11 commits into from
Oct 31, 2022
Merged

Update dependency io.github.microutils:kotlin-logging-jvm to v3 #1529

merged 11 commits into from
Oct 31, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 19, 2022 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.github.microutils:kotlin-logging-jvm 2.1.23 -> 3.0.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Sep 19, 2022 •
edited
Loading

Codecov Report

Merging #1529 (4755b0f) into master (3759312) will increase coverage by 0.00%.
The diff coverage is 73.68%.

@@            Coverage Diff            @@
##             master    #1529   +/-   ##
=========================================
  Coverage     82.09%   82.10%           
- Complexity     2306     2311    +5     
=========================================
  Files           112      112           
  Lines          7793     7801    +8     
  Branches       2011     2015    +4     
=========================================
+ Hits           6398     6405    +7     
  Misses          481      481           
- Partials        914      915    +1
Flag Coverage Δ
unittests 82.10% <73.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt 77.61% <71.42%> (+1.34%) ⬆️
...t/common/config/reader/JsonResourceConfigReader.kt 41.66% <100.00%> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 32.78% <100.00%> (ø)
...otlin/org/cqfn/diktat/common/utils/LoggingUtils.kt 50.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 938 tests   1 923 ✔️  3m 13s ⏱️
   160 suites       15 💤
   160 files           0 ❌

Results for commit 271d9ef.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 923 tests   1 908 ✔️  1m 3s ⏱️
   159 suites       15 💤
   159 files           0 ❌

Results for commit 271d9ef.

♻️ This comment has been updated with latest results.

@nulls
Copy link
Member

nulls commented Sep 19, 2022

Logging is changed, need to test logback in ktlint before merging it

@renovate renovate bot force-pushed the renovate/io.github.microutils-kotlin-logging-jvm-3.x branch 2 times, most recently from d97dac9 to 271d9ef Compare October 15, 2022 17:23
@renovate renovate bot force-pushed the renovate/io.github.microutils-kotlin-logging-jvm-3.x branch from 271d9ef to aacbd7d Compare October 22, 2022 10:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

1 942 tests   1 927 ✔️  4m 15s ⏱️
   160 suites       15 💤
   160 files           0 ❌

Results for commit 64b10f9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

1 923 tests   1 908 ✔️  1m 36s ⏱️
   159 suites       15 💤
   159 files           0 ❌

Results for commit 64b10f9.

♻️ This comment has been updated with latest results.

@nulls nulls self-requested a review October 24, 2022 09:54
@nulls nulls self-assigned this Oct 24, 2022
@renovate renovate bot force-pushed the renovate/io.github.microutils-kotlin-logging-jvm-3.x branch 6 times, most recently from 27726db to 695473d Compare October 29, 2022 20:11
@renovate renovate bot force-pushed the renovate/io.github.microutils-kotlin-logging-jvm-3.x branch from 695473d to c121c7d Compare October 31, 2022 09:13
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2022
View reviewed changes
...-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/config/TestArgumentsReader.kt Fixed Show fixed Hide fixed
...at-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestCheckWarn.kt Fixed Show fixed Hide fixed
diktat-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestCompare.kt Fixed Show fixed Hide fixed
...framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestProcessingFactory.kt Fixed Show fixed Hide fixed
...st-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestComparatorUnit.kt Fixed Show fixed Hide fixed
...t-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/FileComparator.kt Fixed Show fixed Hide fixed
...test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/common/LocalCommandExecutor.kt Fixed Show fixed Hide fixed
@nulls
Copy link
Member

nulls commented Oct 31, 2022

it closes #1424

@nulls
Copy link
Member

nulls commented Oct 31, 2022

Logging is changed, need to test logback in ktlint before merging it

Tested locally: logging does work

14:41:44.726 [pool-1-thread-1] WARN org.cqfn.diktat.ruleset.rules.DiktatRuleSetProvider - Configuration file not found in directory where diktat is run (diktat-analysis.yml) or in the directory where diktat.jar is stored (C:\projects\diktat\diktat-ruleset\target\diktat-analysis.yml) or in system property <diktat.config.path> (null), the default file included in jar will be used. Some configuration options will be disabled or substituted with defaults. Custom configuration file should be placed in diktat working directory if run from CLI or provided as configuration options in plugins.
14:41:44.726 [pool-1-thread-1] DEBUG org.cqfn.diktat.common.config.rules.RulesConfigReader - Using the default diktat-analysis.yml file from the class path
14:41:45.439 [pool-1-thread-1] DEBUG com.pinterest.ktlint.core.internal.RuleRunnerSorter - Rule with id 'standard:indent' should run after the rule with id 'experimental:function-signature'. However, the latter rule is not loaded and is allowed to be ignored. For best results, it is advised load the rule.
14:41:45.440 [pool-1-thread-1] DEBUG com.pinterest.ktlint.core.internal.RuleRunnerSorter - Rules will be executed in order below (unless disabled):

@nulls nulls enabled auto-merge (squash) October 31, 2022 12:42
@nulls nulls merged commit 2a0386e into master Oct 31, 2022
@nulls nulls deleted the renovate/io.github.microutils-kotlin-logging-jvm-3.x branch October 31, 2022 12:49
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 mentioned this pull request Nov 1, 2022
Closed
@nulls nulls linked an issue Nov 15, 2022 that may be closed by this pull request
Migrate to kotlin-logging #1424
Closed
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 mentioned this pull request Mar 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

@nulls nulls Awaiting requested review from nulls

Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to kotlin-logging
2 participants
@nulls @orchestr7