Smoke tests in diktat #1534
Merged
Smoke tests in diktat #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * moved smoke tests to diktat-ruleset
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-ruleset/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSmokeTestBase.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1534 +/- ##
============================================
- Coverage 82.98% 82.09% -0.89%
+ Complexity 2363 2306 -57
============================================
Files 112 112
Lines 7777 7793 +16
Branches 2011 2011
============================================
- Hits 6454 6398 -56
- Misses 442 481 +39
- Partials 881 914 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
diktat-ruleset/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSmokeTest.kt
Fixed
Show fixed
Hide fixed
diktat-ruleset/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSmokeTest.kt
Fixed
Show fixed
Hide fixed
diktat-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/util/TestUtils.kt
Fixed
Show fixed
Hide fixed
* Bugfix for fix mode of AVOID_NULL_CHECK * Added a check for assignment operator when deciding if to put run block or not * Added tests (#1293)
0x6675636b796f75676974687562
approved these changes
Oct 28, 2022
diktat-ruleset/src/test/kotlin/org/cqfn/diktat/ruleset/smoke/DiktatSaveSmokeTest.kt
Outdated
Show resolved
Hide resolved
|
@nulls, I repeatedly receive the following exception when trying to build your branch locally:
The above is a Windows build. I also receive the same error when buildsing using a local TeamCity instance (WSL/Linux):
Let's investigate that, too, before you merge. |
diktat-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/util/TestUtils.kt
Fixed
Show fixed
Hide fixed
diktat-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/util/TestUtils.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/KtlintUtils.kt
Fixed
Show fixed
Hide fixed
diktat-test-framework/src/main/kotlin/org/cqfn/diktat/test/framework/util/TestUtils.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
it's part of #1518