Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the race condition introduced with 34708889da981dd84b1539424fb2398643ac321f #1555

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix the race condition introduced with 34708889da981dd84b1539424fb2398643ac321f #1555

merged 1 commit into from
Nov 9, 2022

Conversation

0x6675636b796f75676974687562
Copy link
Member

@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #1555 (4f01cdd) into master (0cb47bb) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #1555      +/-   ##
============================================
- Coverage     82.15%   82.15%   -0.01%     
  Complexity     2314     2314              
============================================
  Files           112      112              
  Lines          7850     7849       -1     
  Branches       2033     2033              
============================================
- Hits           6449     6448       -1     
  Misses          481      481              
  Partials        920      920
Flag Coverage Δ
unittests 82.15% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 66.66% <ø> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 32.78% <66.66%> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.52% <100.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

1 997 tests   1 982 ✔️  4m 29s ⏱️
   162 suites       15 💤
   162 files           0 ❌

Results for commit 70099a7.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

1 978 tests   1 963 ✔️  1m 15s ⏱️
   161 suites       15 💤
   161 files           0 ❌

Results for commit 70099a7.

@0x6675636b796f75676974687562
Fix the race condition introduced with 3470888
4f01cdd 
### What's done:

 - Original issue: #1548.
 - Original PR: #1553.
 - This change reverts 3470888.
 - Enhances the KDoc of `DiktatRule`.
 - Fixes #1548.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 deleted the bugfix/andrey.shcheglov/a branch November 9, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulls nulls nulls approved these changes

Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Configuration file not found in directory where diktat is run" warning is printed multiple times
2 participants
@0x6675636b796f75676974687562 @nulls