Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface #1601

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

Cheshiriks
Copy link
Member

What's done:

  • fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598

### What's done:
* fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   20m 18s ⏱️ - 4m 33s
2 007 tests ±0  1 992 ✔️ +2  15 💤 ±0  0  - 2 
2 007 runs   - 2  1 992 ✔️ ±0  15 💤 ±0  0  - 2 

Results for commit 8bdb218. ± Comparison against base commit 9456032.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   26m 37s ⏱️ - 8m 41s
1 988 tests ±0  1 969 ✔️ +1  15 💤 ±0  4  - 1 
1 992 runs   - 1  1 973 ✔️ ±0  15 💤 ±0  4  - 1 

For more details on these failures, see this check.

Results for commit 8bdb218. ± Comparison against base commit 9456032.

♻️ This comment has been updated with latest results.

### What's done:
* fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598
### What's done:
* fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598
### What's done:
* fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1601 (8bdb218) into master (9456032) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master    #1601   +/-   ##
=========================================
  Coverage     82.43%   82.43%           
- Complexity     2323     2328    +5     
=========================================
  Files           112      112           
  Lines          7845     7851    +6     
  Branches       2034     2037    +3     
=========================================
+ Hits           6467     6472    +5     
  Misses          453      453           
- Partials        925      926    +1     
Flag Coverage Δ
unittests 82.43% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uleset/rules/chapter3/MultipleModifiersSequence.kt 93.44% <83.33%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

### What's done:
* fixed WRONG_MULTIPLE_MODIFIERS_ORDER bug in SAM interface

Closes #1598
@Cheshiriks Cheshiriks merged commit 1cf345b into master Jan 30, 2023
@Cheshiriks Cheshiriks deleted the bugfix/sam-interface branch January 30, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WRONG_MULTIPLE_MODIFIERS_ORDER triggers on SAM interface
3 participants