Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling a package directive when nodes are moved #1616

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Mar 13, 2023

What's done:

  • excluded PACKAGE_DIRECTIVE from otherNodesBeforeCode
  • added delta to error message of test
  • added two tests expired by provided repro repo

It closes #1612

### What's done:
- excluded `PACKAGE_DIRECTIVE` from `otherNodesBeforeCode`
- added delta to error message of test
- added two tests expired by provided repro repo

It closes #1612
@nulls nulls self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1616 (2582c09) into master (bdc68db) will increase coverage by 0.01%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master    #1616      +/-   ##
============================================
+ Coverage     82.44%   82.45%   +0.01%     
- Complexity     2330     2331       +1     
============================================
  Files           112      112              
  Lines          7860     7861       +1     
  Branches       2043     2044       +1     
============================================
+ Hits           6480     6482       +2     
+ Misses          453      452       -1     
  Partials        927      927              
Flag Coverage Δ
unittests 82.45% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 66.66% <0.00%> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.89% <0.00%> (ø)
.../ruleset/rules/chapter3/files/FileStructureRule.kt 85.35% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 013 tests  +44   1 998 ✔️ +44   22m 20s ⏱️ + 13m 53s
   165 suites +  4        15 💤 ±  0 
   165 files   +  4          0 ±  0 

Results for commit 2582c09. ± Comparison against base commit bdc68db.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   162 files   - 2     162 suites   - 2   33m 43s ⏱️ + 9m 27s
1 990 tests  - 2  1 971 ✔️  - 2  15 💤 ±0  4 ±0 
1 994 runs   - 2  1 975 ✔️  - 2  15 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit 2582c09. ± Comparison against base commit bdc68db.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test default plugin configuration
org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test plugin custom configuration
org.cqfn.diktat.plugin.maven.DiktatMavenPluginIntegrationTest ‑ diktatCheck(TestInfo,MavenExecutionResult)
org.cqfn.diktat.plugin.maven.DiktatMavenPluginIntegrationTest ‑ diktatFix(TestInfo,MavenExecutionResult)
org.cqfn.diktat.ruleset.chapter3.FileStructureRuleFixTest ‑ invalid move in kts files
org.cqfn.diktat.ruleset.chapter3.FileStructureRuleTest ‑ error in moving blocking at the first place

♻️ This comment has been updated with latest results.

@nulls nulls changed the title Handling a package directive in moving nodes Handling a package directive when nodes are moved Mar 13, 2023
@nulls nulls enabled auto-merge (squash) March 13, 2023 15:20
@nulls nulls merged commit 2a56ca7 into master Mar 13, 2023
@nulls nulls deleted the feature/exclusion-package-directive#1612 branch March 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File annotation gives IllegalArgumentException: can only move child of this node
2 participants