Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for tests #1644

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Enhancements for tests #1644

merged 4 commits into from
Mar 27, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Mar 24, 2023

What's done:

  • extracted to common place a common methods

It extracted from #1571

### What's done:
- extracted to common place a common methods

It extracted from #1571

Co-authored-by: Andrey Shcheglov <andrewbass+saveourtool@gmail.com>
@nulls nulls added this to the 2.0.0 milestone Mar 24, 2023
@nulls nulls self-assigned this Mar 24, 2023
@nulls nulls enabled auto-merge (squash) March 24, 2023 10:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   7m 2s ⏱️ -48s
1 367 tests ±0  1 350 ✔️ ±0  17 💤 ±0  0 ±0 
2 746 runs  ±0  2 729 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 48ff515. ± Comparison against base commit d6e9848.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   5m 21s ⏱️ -52s
1 367 tests ±0  1 331 ✔️ ±0  36 💤 ±0  0 ±0 
2 746 runs  ±0  2 710 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 48ff515. ± Comparison against base commit d6e9848.

♻️ This comment has been updated with latest results.

@nulls nulls mentioned this pull request Mar 24, 2023
4 tasks
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1644 (ca2f562) into master (ae84613) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master    #1644      +/-   ##
============================================
- Coverage     81.42%   81.40%   -0.03%     
  Complexity     2326     2326              
============================================
  Files           112      112              
  Lines          7892     7894       +2     
  Branches       2048     2048              
============================================
  Hits           6426     6426              
- Misses          566      568       +2     
  Partials        900      900              
Impacted Files Coverage Δ
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% <0.00%> (ø)
.../kotlin/org/cqfn/diktat/ruleset/utils/FileUtils.kt 71.42% <33.33%> (-28.58%) ⬇️
...at/ruleset/rules/chapter3/files/IndentationRule.kt 75.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls changed the title Enchantments for tests Enhancements for tests Mar 27, 2023
@nulls nulls disabled auto-merge March 27, 2023 09:06
@nulls nulls enabled auto-merge (squash) March 27, 2023 09:06
@nulls nulls merged commit e4e6465 into master Mar 27, 2023
@nulls nulls deleted the feature/test-enchantment#1571 branch March 27, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants