Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diktat command #1649

Merged
merged 19 commits into from
Mar 30, 2023
Merged

Diktat command #1649

merged 19 commits into from
Mar 30, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Mar 28, 2023

What's done:

  • added DiktatProcessor
  • added DiktatProcessCommand
  • reused it in maven-plugin
  • reused it in gradle-plugin

copied from #1563

### What's done:
- added DiktatProcessor
- added DiktatProcessCommand
- reused it in maven-plugin
- reused it in gradle-plugin
@nulls nulls added plugins Plugins for build systems to allow them to run diktat refactoring labels Mar 28, 2023
@nulls nulls added this to the 2.0.0 milestone Mar 28, 2023
@nulls nulls self-assigned this Mar 28, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   161 files     161 suites   5m 51s ⏱️
1 367 tests 1 331 ✔️ 36 💤 0
2 746 runs  2 710 ✔️ 36 💤 0

Results for commit b544b3d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   161 files     161 suites   9m 19s ⏱️
1 367 tests 1 350 ✔️ 17 💤 0
2 746 runs  2 729 ✔️ 17 💤 0

Results for commit b544b3d.

♻️ This comment has been updated with latest results.

@orchestr7
Copy link
Member

orchestr7 commented Mar 28, 2023

image

image

image

image

image

image

image

What's happening? Pure chaos

@nulls
Copy link
Member Author

nulls commented Mar 28, 2023

What's happening?

draft PR is in progress is happening

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1649 (b544b3d) into master (d2a22f0) will decrease coverage by 0.58%.
The diff coverage is 43.56%.

@@             Coverage Diff              @@
##             master    #1649      +/-   ##
============================================
- Coverage     81.31%   80.74%   -0.58%     
- Complexity     2326     2330       +4     
============================================
  Files           113      118       +5     
  Lines          7912     7908       -4     
  Branches       2048     2046       -2     
============================================
- Hits           6434     6385      -49     
- Misses          578      621      +43     
- Partials        900      902       +2     
Impacted Files Coverage Δ
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% <0.00%> (ø)
.../kotlin/org/cqfn/diktat/plugin/maven/DiktatMojo.kt 0.00% <0.00%> (ø)
...n/diktat/ruleset/rules/DiktatRuleSetProviderSpi.kt 0.00% <0.00%> (ø)
.../cqfn/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 31.91% <31.91%> (ø)
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 18.91% <33.33%> (ø)
...g/cqfn/diktat/plugin/gradle/tasks/DiktatFixTask.kt 66.66% <66.66%> (ø)
...cqfn/diktat/plugin/gradle/tasks/DiktatCheckTask.kt 75.00% <75.00%> (ø)
...kotlin/org/cqfn/diktat/ktlint/KtLintRuleWrapper.kt 75.00% <75.00%> (ø)
...lin/org/cqfn/diktat/ktlint/KtLintRuleSetWrapper.kt 77.77% <77.77%> (ø)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

build.gradle.kts Outdated Show resolved Hide resolved
@nulls nulls marked this pull request as ready for review March 29, 2023 12:33
@nulls nulls enabled auto-merge (squash) March 29, 2023 12:40
@nulls nulls merged commit 6b4ecd1 into master Mar 30, 2023
@nulls nulls deleted the feature/diktat-command branch March 30, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Plugins for build systems to allow them to run diktat refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants