Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Diktat's implementation of KtLint's RuleSetProvider #1654

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Apr 3, 2023

What's done:

  • moved Diktat's implementation of RuleSetProvider to diktat-ruleset
  • added initialization of logger to creating of diktat's RuleSetProvider
  • upgraded and share 'kaml'

- moved Diktat's implementation of RuleSetProvider to diktat-ruleset
- added initialization of logger to creating of diktat's `RuleSetProvider`
- upgraded and share 'kaml'
@nulls nulls added enhancement New feature or request refactoring labels Apr 3, 2023
@nulls nulls added this to the 2.0.0 milestone Apr 3, 2023
@nulls nulls self-assigned this Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1654 (a85583a) into master (298f3a9) will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #1654      +/-   ##
============================================
- Coverage     80.76%   80.74%   -0.03%     
  Complexity     2330     2330              
============================================
  Files           118      117       -1     
  Lines          7908     7909       +1     
  Branches       2043     2043              
============================================
- Hits           6387     6386       -1     
- Misses          619      621       +2     
  Partials        902      902              
Impacted Files Coverage Δ
...ktat/common/config/reader/ApplicationProperties.kt 0.00% <0.00%> (ø)
...n/diktat/ruleset/rules/DiktatRuleSetProviderSpi.kt 0.00% <0.00%> (ø)
...t/common/config/reader/JsonResourceConfigReader.kt 41.66% <100.00%> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 36.06% <100.00%> (ø)
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 65.21% <100.00%> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.52% <100.00%> (ø)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 89.07% <100.00%> (ø)
...at/ruleset/rules/chapter2/comments/CommentsRule.kt 88.63% <100.00%> (ø)
...leset/rules/chapter2/comments/HeaderCommentRule.kt 87.40% <100.00%> (ø)
...diktat/ruleset/rules/chapter3/TrailingCommaRule.kt 92.45% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls marked this pull request as ready for review April 3, 2023 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   5m 19s ⏱️ +15s
1 367 tests ±0  1 331 ✔️ ±0  36 💤 ±0  0 ±0 
2 746 runs  ±0  2 710 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit a85583a. ± Comparison against base commit 298f3a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   161 files  ±0     161 suites  ±0   7m 25s ⏱️ + 2m 21s
1 367 tests ±0  1 350 ✔️ ±0  17 💤 ±0  0 ±0 
2 746 runs  ±0  2 729 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit a85583a. ± Comparison against base commit 298f3a9.

♻️ This comment has been updated with latest results.

@nulls nulls enabled auto-merge (squash) April 3, 2023 15:48
@nulls nulls merged commit 08836e7 into master Apr 3, 2023
@nulls nulls deleted the feature/ktlint-ruleset-and-logging branch April 3, 2023 15:49
@nulls nulls mentioned this pull request Apr 5, 2023
@nulls nulls linked an issue Apr 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kaml
2 participants