Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reused 'DiktatProcessor' for inline fix and check #1657

Merged
merged 15 commits into from
Apr 6, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Apr 6, 2023

What's done:

  • Extends DiktatProcessor
  • Supported changes in `DiktatProcessor

### What's done:
- Extends `DiktatProcessor`
- Supported changes in `DiktatProcessor`
@nulls nulls added this to the 2.0.0 milestone Apr 6, 2023
@nulls nulls self-assigned this Apr 6, 2023
@nulls nulls marked this pull request as ready for review April 6, 2023 11:49
@nulls nulls enabled auto-merge (squash) April 6, 2023 11:49
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   162 files  ±0     162 suites  ±0   5m 29s ⏱️ -4s
1 371 tests ±0  1 335 ✔️ ±0  36 💤 ±0  0 ±0 
2 750 runs  ±0  2 714 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 0b61be5. ± Comparison against base commit 0fd74b5.

This pull request removes 44 and adds 44 tests. Note that renamed tests count towards both.
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ don't add the package name to the file in buildSrc path()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name (check)()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name with annotation (check)()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - incorrect warning on file under test directory()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - should not remove special words from file path()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - illegal source set name()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - positive example()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should warn if there is empty domain name()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ shouldn't trigger for gradle script()
…
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ don't add the package name to the file in buildSrc path(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name (check)(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name with annotation (check)(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - incorrect warning on file under test directory(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - should not remove special words from file path(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - illegal source set name(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - positive example(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should warn if there is empty domain name(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ shouldn't trigger for gradle script(Path)
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   162 files  ±0     162 suites  ±0   6m 58s ⏱️ -23s
1 371 tests ±0  1 134 ✔️  - 220  17 💤 ±0  220 +220 
2 750 runs  ±0  2 509 ✔️  - 224  17 💤 ±0  224 +224 

For more details on these failures, see this check.

Results for commit 0b61be5. ± Comparison against base commit 0fd74b5.

This pull request removes 44 and adds 44 tests. Note that renamed tests count towards both.
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ don't add the package name to the file in buildSrc path()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name (check)()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name with annotation (check)()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - incorrect warning on file under test directory()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - should not remove special words from file path()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - illegal source set name()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - positive example()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should warn if there is empty domain name()
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ shouldn't trigger for gradle script()
…
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ don't add the package name to the file in buildSrc path(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name (check)(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ missing package name with annotation (check)(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - incorrect warning on file under test directory(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ regression - should not remove special words from file path(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - illegal source set name(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure - positive example(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should respect KMP project structure(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ should warn if there is empty domain name(Path)
org.cqfn.diktat.ruleset.chapter1.PackageNamingWarnTest ‑ shouldn't trigger for gradle script(Path)
…

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1657 (545e38e) into master (0fd74b5) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1657      +/-   ##
============================================
- Coverage     78.79%   78.75%   -0.05%     
  Complexity     2320     2320              
============================================
  Files           125      125              
  Lines          8108     8111       +3     
  Branches       2046     2047       +1     
============================================
- Hits           6389     6388       -1     
- Misses          820      825       +5     
+ Partials        899      898       -1     
Impacted Files Coverage Δ
...g/cqfn/diktat/ktlint/DiktatProcessorFactoryImpl.kt 0.00% <0.00%> (ø)
.../main/kotlin/org/cqfn/diktat/ktlint/KtLintUtils.kt 16.66% <0.00%> (+1.44%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nulls nulls merged commit 4a9b71f into master Apr 6, 2023
@nulls nulls deleted the feature/diktat-check-fix-ad-hook branch April 6, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants