Removed close outputStream as separate listener #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - added wrapper for ReporterV2 which closes outputstream in afterAll
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/DiktatBaselineFactoryImpl.kt
Fixed
Show fixed
Hide fixed
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/KtLintUtils.kt
Fixed
Show fixed
Hide fixed
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/KtLintUtils.kt
Fixed
Show fixed
Hide fixed
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/KtLintUtils.kt
Fixed
Show fixed
Hide fixed
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/KtLintUtils.kt
Fixed
Show fixed
Hide fixed
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 162 files ±0 162 suites ±0 10m 53s ⏱️ +48s Results for commit fc23765. ± Comparison against base commit 4c90d15. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 162 files ±0 162 suites ±0 9m 24s ⏱️ + 2m 50s Results for commit fc23765. ± Comparison against base commit 4c90d15. ♻️ This comment has been updated with latest results. |
diktat-ktlint-engine/src/main/kotlin/org/cqfn/diktat/ktlint/ReporterV2Wrapper.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
============================================
- Coverage 78.35% 78.19% -0.17%
Complexity 2312 2312
============================================
Files 124 125 +1
Lines 8142 8159 +17
Branches 2060 2061 +1
============================================
Hits 6380 6380
- Misses 858 875 +17
Partials 904 904
|
nulls
commented
Jun 13, 2023
diktat-ktlint-engine/src/main/kotlin/com/saveourtool/diktat/ktlint/KtLintUtils.kt
Outdated
Show resolved
Hide resolved
nulls
requested review from
kgevorkyan,
icemachined,
sanyavertolet,
Cheshiriks,
orchestr7 and
0x6675636b796f75676974687562
orchestr7
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: