New rule to check if @Preview (Jetpack Compose) functions end with 'Preview' suffix and are also private. Part 1 #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Fixed
Show fixed
Hide fixed
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 163 files +1 163 suites +1 6m 34s ⏱️ - 2m 25s Results for commit 491724e. ± Comparison against base commit 6d7f952. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 163 files +1 163 suites +1 6m 39s ⏱️ - 4m 25s Results for commit 491724e. ± Comparison against base commit 6d7f952. ♻️ This comment has been updated with latest results. |
kgevorkyan
force-pushed
the
feature/preview_node
branch
from
b678ca4
to
eab9a02
Compare
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
============================================
+ Coverage 78.20% 78.22% +0.02%
- Complexity 2312 2320 +8
============================================
Files 125 126 +1
Lines 8158 8198 +40
Branches 2061 2065 +4
============================================
+ Hits 6380 6413 +33
- Misses 874 877 +3
- Partials 904 908 +4
|
kgevorkyan
changed the title
nulls
reviewed
Sep 1, 2023
...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/PreviewAnnotationRule.kt
Show resolved
Hide resolved
nulls
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1322
What's done: