Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide fix logic for @Preview functions #1728

Merged
merged 8 commits into from
Sep 5, 2023
Merged

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Sep 4, 2023

Closes #1322

What's done:

  • Provide fix logic
  • Add tests

### What's done:
* wip
### What's done:
* wip
### What's done:
* wip
### What's done:
* wip
### What's done:
* wip
### What's done:
* WIP
### What's done:
* WIP
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1728 (3ed6314) into master (eb65634) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1728      +/-   ##
============================================
- Coverage     78.22%   78.21%   -0.01%     
- Complexity     2320     2324       +4     
============================================
  Files           126      126              
  Lines          8198     8223      +25     
  Branches       2065     2073       +8     
============================================
+ Hits           6413     6432      +19     
+ Misses          877      876       -1     
- Partials        908      915       +7     
Files Changed Coverage Δ
...at/ruleset/rules/chapter3/PreviewAnnotationRule.kt 79.36% <65.38%> (-2.22%) ⬇️
...m/saveourtool/diktat/ruleset/constants/Warnings.kt 97.48% <100.00%> (ø)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  +1     164 suites  +1   5m 43s ⏱️ - 1m 32s
1 377 tests +2  1 341 ✔️ +2  36 💤 ±0  0 ±0 
2 756 runs  +2  2 720 ✔️ +2  36 💤 ±0  0 ±0 

Results for commit 9e9f38f. ± Comparison against base commit eb65634.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  +1     164 suites  +1   7m 2s ⏱️ -52s
1 377 tests +2  1 360 ✔️ +2  17 💤 ±0  0 ±0 
2 756 runs  +2  2 739 ✔️ +2  17 💤 ±0  0 ±0 

Results for commit 9e9f38f. ± Comparison against base commit eb65634.

@kgevorkyan kgevorkyan changed the title Fix logic in @Preview functions Provide fix logic in @Preview functions Sep 5, 2023
@kgevorkyan kgevorkyan marked this pull request as ready for review September 5, 2023 07:16
@kgevorkyan kgevorkyan changed the title Provide fix logic in @Preview functions Provide fix logic for @Preview functions Sep 5, 2023
### What's done:
* Review
@kgevorkyan kgevorkyan enabled auto-merge (squash) September 5, 2023 09:48
@kgevorkyan kgevorkyan merged commit fbe1146 into master Sep 5, 2023
29 of 30 checks passed
@kgevorkyan kgevorkyan deleted the feature/preview_fix branch September 5, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule to check if @Preview (Jetpack Compose) functions end with 'Preview' suffix and are also private
2 participants