Fixed BracesInConditionalsAndLoopsRule and added tests #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - Reworked `insertEmptyBlock()` function for adding empty braces blocks to conditions and `do-while` loop with empty bodies. - Added check for braces block existence to avoid duplicate braces block. - Added tests for conditions including tests for cases of `else if` and cases of empty `if` and `else` bodies. It's part of saveourtool#1737
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
============================================
+ Coverage 76.10% 76.40% +0.30%
- Complexity 2283 2296 +13
============================================
Files 126 126
Lines 8243 8273 +30
Branches 2070 2081 +11
============================================
+ Hits 6273 6321 +48
+ Misses 1050 1027 -23
- Partials 920 925 +5
|
nulls
approved these changes
Sep 25, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
...ain/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/BracesInConditionalsAndLoopsRule.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
insertEmptyBlock()function for adding empty braces blocks to conditions anddo-whileloop with empty bodies.else ifand cases of emptyifandelsebodies.It's part of #1737