Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tests in diktat #1780

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Enhance tests in diktat #1780

merged 1 commit into from
Nov 7, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 7, 2023

What's done:

  • removed unused imports in tests
  • removed deleting temp files in tests
  • added checking assertion for content and status

It's part of #1769

### What's done:
- removed unused imports in tests
- removed deleting temp files in tests
- added checking assertion for content and status
@nulls nulls added the tests Improve testing label Nov 7, 2023
@nulls nulls added this to the 2.0.0 milestone Nov 7, 2023
@nulls nulls self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1780 (01bc5bf) into master (d7fbb5a) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1780   +/-   ##
=========================================
  Coverage     78.25%   78.25%           
  Complexity     2409     2409           
=========================================
  Files           126      126           
  Lines          8453     8453           
  Branches       2149     2149           
=========================================
  Hits           6615     6615           
  Misses          880      880           
  Partials        958      958           
Files Coverage Δ
...m/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt 80.62% <0.00%> (ø)

Copy link
Contributor

github-actions bot commented Nov 7, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   4m 34s ⏱️ - 1m 59s
1 388 tests ±0  1 357 ✔️ ±0  31 💤 ±0  0 ±0 
2 767 runs  ±0  2 736 ✔️ ±0  31 💤 ±0  0 ±0 

Results for commit 01bc5bf. ± Comparison against base commit d7fbb5a.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   11m 6s ⏱️ + 7m 8s
1 388 tests ±0  1 345 ✔️ ±0  43 💤 ±0  0 ±0 
2 767 runs  ±0  2 724 ✔️ ±0  43 💤 ±0  0 ±0 

Results for commit 01bc5bf. ± Comparison against base commit d7fbb5a.

@nulls nulls enabled auto-merge (squash) November 7, 2023 12:30
@nulls nulls merged commit c1c3cab into master Nov 7, 2023
32 of 33 checks passed
@nulls nulls deleted the feature/enhancement-tests branch November 7, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants