Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported multiple reporters in diktat runner #1803

Merged
merged 17 commits into from
Nov 16, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 16, 2023

What's done:

  • refactored DiktatProcessorListener to support a several reporters at once

It closes #1802

@nulls nulls self-assigned this Nov 16, 2023
@nulls nulls marked this pull request as ready for review November 16, 2023 15:49
@nulls nulls enabled auto-merge (squash) November 16, 2023 15:49
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (0c7ed43) 78.38% compared to head (ef4fb6b) 78.33%.

Files Patch % Lines
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 18 Missing ⚠️
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 15 Missing ⚠️
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 14 Missing ⚠️
...om/saveourtool/diktat/ktlint/DiktatReporterImpl.kt 0.00% 7 Missing ⚠️
...rtool/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 76.19% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1803      +/-   ##
============================================
- Coverage     78.38%   78.33%   -0.05%     
- Complexity     2420     2421       +1     
============================================
  Files           126      126              
  Lines          8470     8488      +18     
  Branches       2149     2152       +3     
============================================
+ Hits           6639     6649      +10     
- Misses          871      879       +8     
  Partials        960      960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   7m 55s ⏱️ + 2m 49s
1 395 tests ±0  1 359 ✔️ ±0  36 💤 ±0  0 ±0 
2 774 runs  ±0  2 738 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit ef4fb6b. ± Comparison against base commit 0c7ed43.

Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   7m 26s ⏱️ +30s
1 395 tests ±0  1 378 ✔️ ±0  17 💤 ±0  0 ±0 
2 774 runs  ±0  2 757 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit ef4fb6b. ± Comparison against base commit 0c7ed43.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, looks good, some refactoring, but what was the problem?
Reporters did not work? What was the problem? Can you please add more info to the description of the initial issue?

@nulls nulls merged commit 81a7429 into master Nov 16, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/multiple-reporters-cli#1802 branch November 16, 2023 19:50
@nulls
Copy link
Member Author

nulls commented Nov 17, 2023

Hm, looks good, some refactoring, but what was the problem? Reporters did not work? What was the problem? Can you please add more info to the description of the initial issue?

Hi, updated the issue:

Gradle and maven plugins use diktat runner to run diktat. We need to support multiple reporters in diktat runner to support it in plugins #1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple reporters in diktat runner
2 participants