Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed false positive MISSING_KDOC_ON_FUNCTION on local function (function inside another function) #1848

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

diphtongue
Copy link
Contributor

What's done:

  • Fixed false positive MISSING_KDOC_ON_FUNCTION on local function (function inside another function)
  • Added warning test

Closes #1773

### What's done:
* fix
…ield.

- added `ASTNode.isPrivate()`, `ASTNode.hasSetterGetter()` methods
- added `isPairPropertyBackingField(propertyNode: ASTNode?, backingFieldNode: ASTNode?)` function
- added warning tests.

Closes #1709
* Merge master
- Fixed false positive `MISSING_KDOC_ON_FUNCTION` on local function (function inside another function)
- Added warning test

Closes #1773
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5511527) 78.43% compared to head (325134d) 78.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1848      +/-   ##
============================================
+ Coverage     78.43%   78.45%   +0.02%     
- Complexity     2434     2439       +5     
============================================
  Files           133      133              
  Lines          8616     8624       +8     
  Branches       2171     2174       +3     
============================================
+ Hits           6758     6766       +8     
  Misses          896      896              
  Partials        962      962              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 29s ⏱️ -11s
1 406 tests +4  1 389 ✔️ +4  17 💤 ±0  0 ±0 
2 785 runs  +4  2 768 ✔️ +4  17 💤 ±0  0 ±0 

Results for commit 325134d. ± Comparison against base commit 5511527.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   10m 52s ⏱️ + 4m 50s
1 406 tests +4  1 370 ✔️ +4  36 💤 ±0  0 ±0 
2 785 runs  +4  2 749 ✔️ +4  36 💤 ±0  0 ±0 

Results for commit 325134d. ± Comparison against base commit 5511527.

♻️ This comment has been updated with latest results.

@diphtongue diphtongue merged commit 09edb26 into master Dec 7, 2023
21 checks passed
@diphtongue diphtongue deleted the bugfix/kdoc-local-fun branch December 7, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive MISSING_KDOC_ON_FUNCTION on local function (function inside another function)
4 participants