Fixed bug related to assigning to declared vals inside null-check branches #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nches ### What's done: - Fixed bug related to case when `if-else` block inside `init` or 'run', 'with', 'apply' blocks and there is more than one statement inside 'else' block. This case leads to kotlin compilation error after adding 'run' block instead of 'else' block. Read https://youtrack.jetbrains.com/issue/KT-64174 for more information. - Added new warning tests. Closes #1844
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1851 +/- ##
============================================
+ Coverage 78.42% 78.44% +0.01%
- Complexity 2442 2455 +13
============================================
Files 133 133
Lines 8632 8644 +12
Branches 2179 2184 +5
============================================
+ Hits 6770 6781 +11
Misses 896 896
- Partials 966 967 +1 ☔ View full report in Codecov by Sentry. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 8m 11s ⏱️ + 2m 57s Results for commit d9d97c9. ± Comparison against base commit 0390093. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 7m 14s ⏱️ +23s Results for commit d9d97c9. ± Comparison against base commit 0390093. ♻️ This comment has been updated with latest results. |
kgevorkyan
reviewed
Dec 8, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
kgevorkyan
reviewed
Dec 8, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter4/NullChecksRule.kt
Outdated
Show resolved
Hide resolved
nulls
approved these changes
Dec 11, 2023
kgevorkyan
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
if-elseblock insideinitorrun,with,applyblocks and there is more than one statement insideelseblock. This case leads to kotlin compilation error after addingrunblock instead ofelseblock. Read https://youtrack.jetbrains.com/issue/KT-64174 for more information.Closes #1844