Fixed WRONG_NEWLINES rule to take into account maxCallsInOneLine
#1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - Fixed bug related to case when the number of allowed extension function calls in one line did not match `maxCallsInOneLine` configuration. - Fixed several warning tests. - Added new warning test. Closes #1705
nulls
approved these changes
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1858 +/- ##
=========================================
Coverage 78.39% 78.39%
Complexity 2456 2456
=========================================
Files 133 133
Lines 8645 8645
Branches 2184 2184
=========================================
Hits 6777 6777
Misses 898 898
Partials 970 970 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
maxCallsInOneLineconfiguration.Closes #1705