Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated arguments for diktat-cli #1860

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Updated arguments for diktat-cli #1860

merged 9 commits into from
Dec 15, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Dec 13, 2023

What's done:

  • reporter is optional now
  • output is required now when reporter is provided
  • renamed parameters are related to plain output
  • added a new type PLAIN_GROUP_BY_FILE

It closes #1793

### What's done:
- added calculating version from tag ref
@nulls nulls self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (02c1a7c) 78.55% compared to head (0029cee) 78.40%.
Report is 1 commits behind head on master.

Files Patch % Lines
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 61 Missing ⚠️
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 9 Missing ⚠️
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt 73.68% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1860      +/-   ##
============================================
- Coverage     78.55%   78.40%   -0.15%     
- Complexity     2456     2463       +7     
============================================
  Files           133      133              
  Lines          8654     8688      +34     
  Branches       2189     2200      +11     
============================================
+ Hits           6798     6812      +14     
- Misses          882      897      +15     
- Partials        974      979       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   11m 43s ⏱️ + 4m 56s
1 423 tests ±0  1 386 ✔️ ±0  37 💤 ±0  0 ±0 
2 802 runs  ±0  2 765 ✔️ ±0  37 💤 ±0  0 ±0 

Results for commit 0029cee. ± Comparison against base commit d14f27d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 25s ⏱️ +11s
1 423 tests ±0  1 406 ✔️ ±0  17 💤 ±0  0 ±0 
2 802 runs  ±0  2 785 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 0029cee. ± Comparison against base commit d14f27d.

♻️ This comment has been updated with latest results.

@nulls nulls changed the title Fixed release.yml Update diktat-cli arguments Dec 15, 2023
@nulls nulls added this to the 2.0.0 milestone Dec 15, 2023
@nulls nulls changed the title Update diktat-cli arguments Updated arguments for diktat-cli Dec 15, 2023
@nulls nulls marked this pull request as ready for review December 15, 2023 12:54
@nulls nulls merged commit 6cb0093 into master Dec 15, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/fix-release-yml branch December 15, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README.md after 2.0
2 participants