Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin from 1.4.32 to 1.5 #856

Merged
merged 11 commits into from
May 13, 2021
Merged

Update kotlin from 1.4.32 to 1.5 #856

merged 11 commits into from
May 13, 2021

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Apr 27, 2021

What's done:

  • Updated kotlin
  • Enabled snapshot jacoco
  • Updated settings in diktat configs
  • Updated gradle to 6.9

TODO:

  • remove explicit compiler flag for IR, since it's default now
  • use fixed version of jacoco snapshot (?) Update jacoco to 0.8.7, it's already out

### What's done:
* Updated kotlin
* Enabled snapshot jacoco
* Updated settings in diktat configs
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #856 (0dd2012) into master (de04b9b) will increase coverage by 0.43%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #856      +/-   ##
============================================
+ Coverage     83.51%   83.94%   +0.43%     
- Complexity     2215     2308      +93     
============================================
  Files           101      100       -1     
  Lines          5689     5893     +204     
  Branches       1628     1739     +111     
============================================
+ Hits           4751     4947     +196     
- Misses          256      261       +5     
- Partials        682      685       +3     
Flag Coverage Δ Complexity Δ
unittests 83.94% <90.90%> (+0.43%) 2308.00 <1.00> (+93.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 35.29% <0.00%> (ø) 3.00 <0.00> (-1.00)
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 84.14% <100.00%> (-0.04%) 90.00 <1.00> (+3.00) ⬇️
...at/ruleset/rules/chapter3/files/IndentationRule.kt 85.91% <100.00%> (+1.35%) 46.00 <0.00> (+1.00)
...diktat/ruleset/rules/chapter6/AvoidUtilityClass.kt 77.27% <100.00%> (ø) 16.00 <0.00> (+1.00)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 85.54% <100.00%> (+0.76%) 0.00 <0.00> (ø)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 86.07% <100.00%> (+0.36%) 0.00 <0.00> (ø)
...otlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt 91.17% <100.00%> (ø) 0.00 <0.00> (ø)
...n/kotlin/org/cqfn/diktat/ruleset/utils/PsiUtils.kt 50.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
.../cqfn/diktat/ruleset/rules/chapter5/CustomLabel.kt 84.61% <0.00%> (-7.70%) 10.00% <0.00%> (ø%)
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 70.58% <0.00%> (-5.89%) 8.00% <0.00%> (+1.00%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de04b9b...0dd2012. Read the comment docs.

### What's done:
* Fixed deprecation warnings
### What's done:
* Code style
### What's done:
* Code style
### What's done:
* Removed jacoco snapshot
* Removed explicit IR flag
### What's done:
* Bump gradle to 6.9, use kotlin plugin 1.4.20
@petertrr petertrr requested a review from orchestr7 May 11, 2021 08:04
@petertrr petertrr marked this pull request as ready for review May 11, 2021 08:04
@petertrr petertrr added this to the 0.6.0 milestone May 11, 2021
@petertrr petertrr merged commit a13f019 into master May 13, 2021
@petertrr petertrr deleted the infra/kotlin-1.5 branch May 13, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants