Value Parameter in Magic Number Rule #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: Added new flag to handle value parameter Added this flag to config files Added tests
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=========================================
Coverage 83.61% 83.61%
- Complexity 2208 2209 +1
=========================================
Files 101 101
Lines 5669 5671 +2
Branches 1614 1615 +1
=========================================
+ Hits 4740 4742 +2
Misses 256 256
Partials 673 673
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: Fixed according to our code style
petertrr
reviewed
May 11, 2021
petertrr
reviewed
May 11, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed after review
### What's done: Fixed according to our code style
petertrr
reviewed
May 11, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/MagicNumberRule.kt
Show resolved
Hide resolved
### What's done: Added test after review
### What's done: Fixed test
petertrr
reviewed
May 11, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/MagicNumberRule.kt
Show resolved
Hide resolved
petertrr
approved these changes
May 11, 2021
petertrr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: