Various updates on grammar rules and test cases #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonZiweiWang
force-pushed
the
Feature-10094-Improve-syntax-parser
branch
from
1426bf2 to
ba8086b
Compare
WilsonZiweiWang
changed the title
|
Changes related to it have been reverted. |
|
Add more Python keywords for highlighting; |
ioioioio
reviewed
Oct 5, 2023
WilsonZiweiWang
force-pushed
the
Feature-10094-Improve-syntax-parser
branch
from
993c5a3 to
cdaf147
Compare
deribaucourt
reviewed
Oct 6, 2023
deribaucourt
reviewed
Oct 6, 2023
WilsonZiweiWang
changed the title
WilsonZiweiWang
force-pushed
the
Feature-10094-Improve-syntax-parser
branch
from
cdaf147 to
75438c2
Compare
|
Repushed the changes on |
deribaucourt
requested changes
Oct 12, 2023
We have the option to squash all the commits when this PR is merged. But I reset the commits, it should look better now. |
1. Use boundary anchor 2. Add python keywords
WilsonZiweiWang
force-pushed
the
Feature-10094-Improve-syntax-parser
branch
from
b0a8115 to
50311f0
Compare
deribaucourt
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Replace hard-coded operators with.*to match all function and variable names regardless of what comes after the:since we don't care about them for now.2. Make sure the names following a:won't be seen as references to a declared object.3. Use the injection approach to apply necessary grammar rules for bitbake conf files4. Implement a minimum set of rules including variables, variable expansion, some keywords etc to reduce conflicts with non-bitbake .conf filesChanges related to what is above have been reverted. This PR is now for grammar rule changes in
bitbake.tmLanguage.jsonand test cases