Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add the setting to auto fix eslint errors on save #24

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

WilsonZiweiWang
Copy link
Collaborator

This setting enables auto fix for eslint errors on save

Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people arguing whether settings.json should be included into source control or not: https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control

There's no definitive answer. So lets just merge and learn from it.

@WilsonZiweiWang WilsonZiweiWang merged commit 2f57cff into staging Oct 13, 2023
@WilsonZiweiWang WilsonZiweiWang deleted the Fix-eslint-on-save branch October 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants