Package vsix #39
Package vsix #39
Conversation
deribaucourt
force-pushed
the
package-vsix
branch
5 times, most recently
from
45c68d1 to
e7bf691
Compare
deribaucourt
force-pushed
the
package-vsix
branch
from
e7bf691 to
610da7e
Compare
In order to package the client extension, it needs to have the server compiled into it.
Updates all package.json. Some dependencies were missing when packaging the client extension. Some were moved to the main package.json which is responsible for compiling jest unit tests and integration tests.
With the previous updates to package.json, regenerate the lock files with Node 20.
In order to package the client extension in a .vsix file, we need to install the server node_modules into the client extension.
The .vscodeignore file was also updated to only contained the required files at runtime.
This file must be present in the server directory for Jest tests. In production, it must also be in the client directory.
Update the paths with the change from server/out to client/server for all our typescript tools. Also update paths to ignore the .vsix packaging artifacts.
Take into account the recent move from server/out to client/server.
These TODO are either done, or fell out of scope.
The .vsix can be installed in vscode. This commit checks that the compilation works and archives the .vsix file as an artifact.
The badge will display the last pipeline result on the master branch. So it won't be affected by current PR which might fail. Only releases PR to master will affect the badge.
deribaucourt
force-pushed
the
package-vsix
branch
from
610da7e to
07f8af4
Compare
client/package-lock.json
Outdated
There was a problem hiding this comment.
This file should not have been added. You can do installations and stuff from the root package: npm install stuff --workspace client. You can also update the package-lock.json file simply by calling "npm install" from the root package.
There was a problem hiding this comment.
Actually the client/ directory is the thing that gets packaged into the .vsix. So it needs to have client/node_modules as well as client/server/node_module. This follows the VSCode language server example packaging: https://github.com/microsoft/vscode-extension-samples/blob/main/lsp-sample/client/package-lock.json
client/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "vscode-languageclient": "^8.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^20.6.2", |
There was a problem hiding this comment.
I added a new commit for that.
| -p2222:22 \ | ||
| -v "$(realpath ../..)":'/home/yoctouser/vscode-bitbake' \ | ||
| --workdir '/home/yoctouser/vscode-bitbake/integration-tests/project-folder' \ | ||
| -it vscode-test |
There was a problem hiding this comment.
should it be vscode-bitbake-test?
Otherwise I get the following error: Unable to find image 'vscode-test:latest' locally
| "fetch": "npm run fetch:poky", | ||
| "fetch:poky": "mkdir -p resources/poky && curl -L -o resources/poky.tar.bz2 https://downloads.yoctoproject.org/releases/yocto/yocto-4.2.3/poky-aa63b25cbe25d89ab07ca11ee72c17cab68df8de.tar.bz2 && tar -xvjf resources/poky.tar.bz2 -C resources", | ||
| "compile": "tsc -b", | ||
| "compile": "tsc -b && npm run compile:server && npm run compile:client", |
There was a problem hiding this comment.
I think we should move at some point compile:server and compile:client to their respective packages.json so we can call all of them on one shot with npm run compile --workspaces. Especially with the "common" package coming soon and adding to it.
There was a problem hiding this comment.
I had to remove the workspace property since it could not generate client/node_modules which is required by vsce.
The presented package.json architecture fulfills current needs. I suggest merging it that way and if new needs arise later, modify it.
There was a problem hiding this comment.
The current package.json fulfills the packaging and testing needs we have while following the example documented example for VSCode language server extensions. I suggest merging this version and mofifying it when new needs arise.
server/package-lock.json
Outdated
There was a problem hiding this comment.
same, it should not be there
deribaucourt
force-pushed
the
package-vsix
branch
from
07f8af4 to
88b4df7
Compare
Some dependencies were moved to devDependencies. I also made sure the .vsix didn't contain the devDependencies.
No description provided.