Stop monkey-patching String with #snakecase #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Savon gave it breaking change, not monkeyPatch
You changed the util so it's hard to be compatible with Nori when somebody used pointed out in readme before 'StringKey'.snakecase It's of course good to not pollute String class, but it should be minor bump I suppose instead of bugfix |
|
Yes in hindsight it would’ve been a point release as with Savon - sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Fixes #101
Stops the monkey patching of
#snakecaseontoString.Did you add tests for your changes?
Updated existing
String#snakecasetests to testNori::StringUtils.snakecase.Summary of changes
Moved
String#snakecaseinto a module class method.Other information
Related to savonrb/savon#984