Improved xs:time/xs:date/xs:dateTime regular expression matcher #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
I've run into an issue while consuming a Savon SOAP response, a file name (doc-2011-09-09.pdf) containing a date string was converted into a date object, while it shouldn't be.
After digging into Nori, I found the 'advanced_typecasting' method in 'XMLUtilityNode' class is using a flawed regular expression to match strings to convert, which causes this issue.
I've updated the regular expression to make it work for me, and here's the commit for you to consider in case you want to update your code and gem.
Thanks.
Cheers,
Felix