Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved xs:time/xs:date/xs:dateTime regular expression matcher #17

Merged
merged 1 commit into from
Jun 29, 2012

Conversation

moom
Copy link
Contributor

@moom moom commented Jun 29, 2012

Hi Daniel,

I've run into an issue while consuming a Savon SOAP response, a file name (doc-2011-09-09.pdf) containing a date string was converted into a date object, while it shouldn't be.

After digging into Nori, I found the 'advanced_typecasting' method in 'XMLUtilityNode' class is using a flawed regular expression to match strings to convert, which causes this issue.

I've updated the regular expression to make it work for me, and here's the commit for you to consider in case you want to update your code and gem.

Thanks.

Cheers,
Felix

@rubiii rubiii merged commit e722316 into savonrb:master Jun 29, 2012
@rubiii
Copy link
Contributor

rubiii commented Jun 29, 2012

released as v1.1.1. thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants