Scrub invalid characters from source XML #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alethea
force-pushed
the
scrub_xml
branch
2 times, most recently
from
fa1780e to
37d0191
Compare
Nori::Parser has a new option, :scrub_xml, which defaults to true, when it's true, the parser will clean invalid or undefined characters from the string using String#scrub if it's available or String#encode otherwise.
|
Thanks for contributing this pull request @alethea! In particular, I appreciate you changing the old stubbed tests (which were probably in the wrong place) to instead test the behavior that we care about (scrubbing out invalid characters) rather than the implementation (sending a particular message to the string). That's awesome. I care a lot about good testing hygiene, and that's something I've wanted to invest in since I started maintaining, but never really managed to dedicate enough time to. Thank you. A thousand times, thank you. |
tjarratt
added a commit
that referenced
this pull request
Mar 4, 2016
Scrub invalid characters from source XML
|
You're welcome! Thanks for the speedy response and review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nori::Parserhas a new option,:scrub_xml, which defaults to true, when it's true, the parser will clean invalid or undefined characters from the string usingString#scrubif it's available (Ruby 2.1 or later) orString#encodeotherwise. This should allow documents containing invalid characters to still be parsed.