Support Savon version 2 requests #7
Conversation
It's unlikely that anyone will ever be MITM'd and receive a bad gem, but it's a best practice to use ssl for installing gems
Needs tests but the interface between savon-multipart and savon just became a whole lot smaller.
This isn't necessary anymore because Savon does not have a global configuration manager in version 2. Instead, when you instantiate a client, you have an option to pass in some options there, and you can also pass in options (that will take precedence over the previous ones) when you call the #call method on a Savon::Client Neat, and with way less global state than before. Either way, this spec helper isn't needed anymore.
Nothing crazy, just changed how we create the response
|
Just started using this a bit more in production, fixed a bug with the |
I had previously only been using the #to_xml and #parts methods, so I hadn't run this this before. The issue was that Nori does not know how to handle an instance of Mail::Body rather than a string. It seems that the correct thing to do is to just return a string. Also brought in some same defaults from Savon::GlobalOptions for this test. Before it wouldn't have been possible to actually call the #body method in the tests because we didn't specify how to take the response body tags and turn them into snakecase symbols
|
@tjarratt i just merged savonrb/savon#434 and added you as a maintainer to the savonrb organization. remember, with great power comes great responsibility :) @tjarratt @ebeigarts do you both have an account at rubygems.org? if you give me your email address associated with that account, i will add you as an owner for the multipart gem so you can release on your own schedule. |
Unsure whether this will pass on ree, but it will pass on all supported versions of 1.8.7 (p371 mri, jruby18-mode and rubinius).
|
Ah, many thanks @rubiii -- I promise to always use this power for good, and to never let my passwords fall into the wrong hands :) I'm "nearbuy_tim" on rubygems.org, but I'm fine delegating to @ebeigarts for future releases. My projects' Gemfiles already specify a branch, and it isn't much work to maintain that much until a new release. |
|
👍 Hi folks I would like to thank all of you for giving savon 2 support to savon-multipart. |
|
@soundarapandian i hear you :) i'll make sure this gets released for version 2 after the "push to github" milestone of savonrb/wasabi#27 is done. |
|
This has been merged for some time now. Closing since I just published a new version to ruby gems.org |
|
Feels so weird to merge and close my own pull request, but whatever. C'est la vie. |
I wanted to use Savon version 2 and despaired that savon-multipart did not support it, so I've updated this gem and cleaned up as much of the low hanging fruit as I could.
The corresponding pull request for Savon is here