Add log_filter to filter out sensitive element values #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be very useful |
|
i agree. i'll merge asap. thank you @THEY |
|
merged and edited to not even try to filter anything else than soap request xml at e5614e6. |
|
released with v0.9.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to log messages, but wanted to filter out sensitive element values (i.e. credit card numbers, etc).
This patch adds a log_filter configuration variable - which takes an array of strings. The filter will find xml elements (while ignoring namespaces) in log_filter array and will replace it with "FILTERED".
Tests included as well.