Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the global :proxy setting for WSDL requests, too. #378

Merged
merged 2 commits into from
Jan 26, 2013
Merged

Respect the global :proxy setting for WSDL requests, too. #378

merged 2 commits into from
Jan 26, 2013

Conversation

larskanis
Copy link
Contributor

... not sure, if this could be tested per spec.

@rubiii rubiii mentioned this pull request Jan 25, 2013
Closed
@rubiii
Copy link
Contributor

rubiii commented Jan 25, 2013

thanks @larskanis. this is currently discussed at #367.
ps. everything can be tested :)

@DrXyzzy
Copy link

DrXyzzy commented Jan 25, 2013

+1. thank you @larskanis. proxy was the next problem I was having with savon 2 after wsdl basic auth. your patch fixes it.

@larskanis
Copy link
Contributor Author

Regarding the discussion at #367: for the :proxy setting it certainly doesn't make sense to split between WSDL and other requests.

@rubiii
Copy link
Contributor

rubiii commented Jan 25, 2013

@larskanis thanks. hope to get some more opinions on those two issues.

@rubiii rubiii merged commit b7504da into savonrb:master Jan 26, 2013
@rubiii
Copy link
Contributor

rubiii commented Jan 26, 2013

merged and pushed to master. please test and let me know whether it works.

@DrXyzzy
Copy link

DrXyzzy commented Jan 26, 2013

Pulled master (with refactored request.rb). It passes my test, which uses both proxy and basic auth, for wsdl and SOAP query. Nice.

@rubiii
Copy link
Contributor

rubiii commented Jan 26, 2013

@DrXyzzy thanks!

@janraasch janraasch mentioned this pull request Mar 31, 2016
Merged
pcai pushed a commit that referenced this pull request Aug 22, 2017
@janraasch @pcai
Add headers configuration to WSDLRequest#build (#753)
2bd15ef 
e.g. some proxy servers may require

```ruby
{ "Proxy-Authorization" => "Basic base64EncodedAuthHash" }
```

as part of the headers.

In particular we ran into issues with using the Proximo Heroku Add-On.

This fixes #750 and may be considered as a late addition to #378.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larskanis @rubiii @DrXyzzy