Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOAPFault wrongly assumes that the hash keys will be symbols #393

Closed
wants to merge 1 commit into from
Closed

SOAPFault wrongly assumes that the hash keys will be symbols #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions spec/savon/soap_fault_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
describe Savon::SOAPFault do
let(:soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori }
let(:soap_fault2) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault12)), nori }
let(:soap_fault_nc) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault)), nori_no_convert }
let(:soap_fault_nc2) { Savon::SOAPFault.new new_response(:body => Fixture.response(:soap_fault12)), nori_no_convert }
let(:another_soap_fault) { Savon::SOAPFault.new new_response(:body => Fixture.response(:another_soap_fault)), nori }
let(:no_fault) { Savon::SOAPFault.new new_response, nori }

let(:nori) { Nori.new(:strip_namespaces => true, :convert_tags_to => lambda { |tag| tag.snakecase.to_sym }) }
let(:nori_no_convert) { Nori.new(:strip_namespaces => true, :convert_tags_to => nil) }

it "inherits from Savon::Error" do
expect(Savon::SOAPFault.ancestors).to include(Savon::Error)
Expand Down Expand Up @@ -52,6 +55,14 @@
it "returns a SOAP fault message (with different namespaces)" do
expect(another_soap_fault.send method).to eq("(ERR_NO_SESSION) Wrong session message")
end

it "works even if the keys are different in a SOAP 1.1 fault message" do
soap_fault_nc.send method
end

it "works even if the keys are different in a SOAP 1.2 fault message" do
soap_fault_nc2.send method
end
end
end

Expand Down Expand Up @@ -82,6 +93,10 @@

expect(soap_fault2.to_hash).to eq(expected)
end

it "works even if the keys are different" do
soap_fault_nc2.to_hash
end
end

def new_response(options = {})
Expand Down