fix: handle missing nested values

sbatson5 · Dec 3, 2024 · ef7cbca · ef7cbca
1 parent db2eb92
commit ef7cbca
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/__tests__/query.test.js b/__tests__/query.test.js
@@ -221,6 +221,18 @@ describe('Queries', () => {
     expect(color).toEqual('brown');
   });
 
+  test('it can handle missing nested values', async () => {
+    const res = await db
+      .collection('animals')
+      .where('id', '==', 'cow')
+      .select('size.height.shoulder')
+      .get();
+
+    expect(res).toHaveProperty('size', 1);
+    const data = res.docs[0].data();
+    expect(data).toHaveProperty('size', {});
+  });
+
   // TODO should add support
   test.skip('it can select many nested values', async () => {
     const res = await db

diff --git a/src/mocks/helpers/buildDocFromHash.js b/src/mocks/helpers/buildDocFromHash.js
@@ -62,8 +62,13 @@ module.exports = function buildDocFromHash(hash = {}, id = 'abc123', selectField
 };
 
 function buildDocFromPath(data, path) {
+  if (data === undefined || data === null) {
+    return {};
+  }
+
   const [root, ...subPath] = path;
+  const rootData = data[root];
   return {
-    [root]: subPath.length ? buildDocFromPath(data[root], subPath) : data[root]
+    [root]: subPath.length ? buildDocFromPath(rootData, subPath) : rootData
   };
 }