Skip to content

Commit

Permalink
Temporarily disable pch/gch tests while LLVM rolls in (emscripten-cor…
Browse files Browse the repository at this point in the history
…e#20283)

It seems LLVM has changed both the default output from gch to pch,
and also the contents of pch file metadata (which we check) are now
quite different as well.

This will unbreak the roller, and then we can adjust the test for new LLVM.
  • Loading branch information
kripken authored Sep 18, 2023
1 parent cb9471c commit 390011c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -4107,6 +4107,8 @@ def test_precompiled_headers_warnings(self):
'pch': ['pch'],
})
def test_precompiled_headers(self, suffix):
self.skipTest('disable while LLVM changes to pch roll in (new defaults&output)')

create_file('header.h', '#define X 5\n')
self.run_process([EMCC, '-xc++-header', 'header.h', '-c'])
self.assertExists('header.h.gch') # default output is gch
Expand Down

0 comments on commit 390011c

Please sign in to comment.