Skip to content

Commit

Permalink
[test] Temporarily disable wasm64 + threads browser test (emscripten-…
Browse files Browse the repository at this point in the history
…core#20263)

We are using `index: 'i64'` for our memory type which isn't
currently compatible with the chrome unstable build we use
in CI but will be once this change makes it into an unstable
release: https://chromium-review.googlesource.com/c/v8/v8/+/4807493.
  • Loading branch information
sbc100 authored Sep 15, 2023
1 parent aab180a commit 783d0b8
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions test/test_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -4714,7 +4714,9 @@ def test_fetch_cached_xhr(self):

# Tests that response headers get set on emscripten_fetch_t values.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
@also_with_wasm2js_or_wasm64
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm2js_or_wasm64
@also_with_wasm2js
@requires_threads
def test_fetch_response_headers(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand Down Expand Up @@ -4747,7 +4749,9 @@ def test_fetch_xhr_abort(self):
# Tests emscripten_fetch() usage in synchronous mode when used from the main
# thread proxied to a Worker with -sPROXY_TO_PTHREAD option.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
@also_with_wasm64
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm2js_or_wasm64
@also_with_wasm2js
@requires_threads
def test_fetch_sync_xhr(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand All @@ -4756,7 +4760,8 @@ def test_fetch_sync_xhr(self):
# Tests emscripten_fetch() usage when user passes none of the main 3 flags (append/replace/no_download).
# In that case, in append is implicitly understood.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
@also_with_wasm64
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm64
@requires_threads
def test_fetch_implicit_append(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand Down Expand Up @@ -5589,7 +5594,8 @@ def test_full_js_library_strict(self):
# Tests the AudioWorklet demo
@parameterized({
'': ([],),
'memory64': (['-sMEMORY64', '-Wno-experimental'],),
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# 'memory64': (['-sMEMORY64', '-Wno-experimental'],),
'with_fs': (['--preload-file', test_file('hello_world.c') + '@/'],),
'closure': (['--closure', '1', '-Oz'],),
'asyncify': (['-sASYNCIFY'],),
Expand Down

0 comments on commit 783d0b8

Please sign in to comment.