Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor app initialization #329

Merged
merged 1 commit into from
Dec 13, 2023
Merged

refactor app initialization #329

merged 1 commit into from
Dec 13, 2023

Conversation

chdsbd
Copy link
Collaborator

@chdsbd chdsbd commented Dec 13, 2023

Now we display an error message when no enough required parameters are supplied:

Upload to GitHub failed: Missing GitHub credentials:

For a GitHub token:
--github-token is required

For a GitHub App:
--github-app-id is required
--github-install-id is required
--github-private-key or --github-private-key-base64 is required

@chdsbd chdsbd requested a review from sbdchd December 13, 2023 01:12
@chdsbd chdsbd added the automerge automerge with kodiak label Dec 13, 2023
@kodiakhq kodiakhq bot merged commit 2133edb into master Dec 13, 2023
16 checks passed
@kodiakhq kodiakhq bot deleted the chris/ref-app-initialization branch December 13, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge automerge with kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chdsbd @sbdchd