feat: add a flag & config for skipping path glob patterns #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
chdsbd
approved these changes
May 31, 2024
| @@ -27,6 +27,7 @@ squawk-parser = { version = "0.0.0", path = "../parser" } | |||
| squawk-linter = { version = "0.0.0", path = "../linter" } | |||
| squawk-github = { version = "0.0.0", path = "../github" } | |||
| toml = "0.5.9" | |||
| glob = "0.3.1" | |||
There was a problem hiding this comment.
I think eventually it'd be cool to support globs for finding paths
| /// | ||
| /// --exclude-path='*user_ids.sql' | ||
| #[structopt(long = "exclude-path")] | ||
| excluded_path: Option<Vec<String>>, |
There was a problem hiding this comment.
I removed the use_delimiter setting because I think paths can containe ,. Now users can specify the --exclude-path flag multiple times instead.
|
Thank you for the PR @rdaniels6813! |
|
squawk-cli@0.29.0 has been publish to NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CLI flag as well as a field in the config file for skipping paths using glob patterns. This is useful for introducing the linter on an already live service which had linter warnings on previous migrations.